[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #2748: [Snapshot] Modify the prefer snapshot version

[GitBox <gi...@apache.org>]

kangkaisen commented on a change in pull request #2748: [Snapshot] Modify the prefer snapshot version
URL: https://github.com/apache/incubator-doris/pull/2748#discussion_r366147077
 
 

 ##########
 File path: gensrc/thrift/AgentService.thrift
 ##########
 @@ -178,7 +178,7 @@ struct TSnapshotRequest {
     7: optional bool list_files
     // if all nodes has been upgraded, it can be removed.
     8: optional bool allow_incremental_clone
-    9: optional i32 preferred_snapshot_version = 1  // request preferred snapshot version, default value is 1 for old version be
+    9: optional i32 preferred_snapshot_version = Types.TPREFER_SNAPSHOT_REQ_VERSION
 
 Review comment:
   You change the default value, is there no compatibility ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org