You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "xuzifu666 (via GitHub)" <gi...@apache.org> on 2023/02/13 08:30:20 UTC
[GitHub] [flink] xuzifu666 opened a new pull request, #21914: add warn info to user when NoNodeException happend
xuzifu666 opened a new pull request, #21914:
URL: https://github.com/apache/flink/pull/21914
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
*(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them on each deployment (during recovery).)*
## Brief change log
*(for example:)*
- *The TaskInfo is stored in the blob store on job creation time as a persistent artifact*
- *Deployments RPC transmits only the blob storage reference*
- *TaskManagers retrieve the TaskInfo from the blob cache*
## Verifying this change
Please make sure both new and modified tests in this PR follows the conventions defined in our code quality guide: https://flink.apache.org/contributing/code-style-and-quality-common.html#testing
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe tests)*.
*(or)*
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (100MB)*
- *Extended integration test for recovery after master (JobManager) failure*
- *Added test that validates that TaskInfo is transferred only once across recoveries*
- *Manually verified the change by running a 4 node cluster with 2 JobManagers and 4 TaskManagers, a stateful streaming program, and killing one JobManager and two TaskManagers during the execution, verifying that recovery happens correctly.*
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / no)
- The serializers: (yes / no / don't know)
- The runtime per-record code paths (performance sensitive): (yes / no / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
- The S3 file system connector: (yes / no / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] xuzifu666 commented on pull request #21914: [FLINK-31035] add warn info to user when NoNodeException happend
Posted by "xuzifu666 (via GitHub)" <gi...@apache.org>.
xuzifu666 commented on PR #21914:
URL: https://github.com/apache/flink/pull/21914#issuecomment-1630596752
cc @reswqa @rkhachatryan hi，this pr would closed，and move it to https://github.com/apache/flink/pull/22980
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] xuzifu666 commented on pull request #21914: [FLINK-31035] add warn info to user when NoNodeException happend
Posted by "xuzifu666 (via GitHub)" <gi...@apache.org>.
xuzifu666 commented on PR #21914:
URL: https://github.com/apache/flink/pull/21914#issuecomment-1428992853
@zentol
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rkhachatryan commented on a diff in pull request #21914: [FLINK-31035] add warn info to user when NoNodeException happend
Posted by "rkhachatryan (via GitHub)" <gi...@apache.org>.
rkhachatryan commented on code in PR #21914:
URL: https://github.com/apache/flink/pull/21914#discussion_r1125727845
##########
flink-runtime/src/main/java/org/apache/flink/runtime/zookeeper/ZooKeeperStateHandleStore.java:
##########
@@ -364,6 +364,7 @@ public Collection<String> getAllHandles() throws Exception {
return client.getChildren().forPath(path);
} catch (KeeperException.NoNodeException ignored) {
// Concurrent deletion, retry
+ LOG.warn("NoNodeException happend, and retrying again.");
Review Comment:
> we offten occur zk leader change when zxid over it's range, get the message can tell us in time.
It looks like the change is needed to **debug** the issues in a specific ZK-Flink setup, rather than in Flink itself.
So I'd suggest to log it on `debug` level:
```suggestion
} catch (KeeperException.NoNodeException e) {
LOG.debug("Unable to get all handles, retrying (ZNode was likely deleted concurrently: {})", e.getMessage());
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rkhachatryan commented on pull request #21914: [FLINK-31035] add warn info to user when NoNodeException happend
Posted by "rkhachatryan (via GitHub)" <gi...@apache.org>.
rkhachatryan commented on PR #21914:
URL: https://github.com/apache/flink/pull/21914#issuecomment-1455630852
Hi @xuzifu666,
could you please squash the commits into one and format the commit message according to [Flink guide](https://flink.apache.org/how-to-contribute/code-style-and-quality-pull-requests/#4-commit-naming-conventions) (similar to the PR title)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] xuzifu666 commented on pull request #21914: [FLINK-31035] add warn info to user when NoNodeException happend
Posted by "xuzifu666 (via GitHub)" <gi...@apache.org>.
xuzifu666 commented on PR #21914:
URL: https://github.com/apache/flink/pull/21914#issuecomment-1455300436
@rkhachatryan ok，get
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] reswqa commented on pull request #21914: [FLINK-31035] add warn info to user when NoNodeException happend
Posted by "reswqa (via GitHub)" <gi...@apache.org>.
reswqa commented on PR #21914:
URL: https://github.com/apache/flink/pull/21914#issuecomment-1456213270
IMH, we should only have one commit like `[FLINK-31035][runtime] Log debug message when NoNodeException thrown while getAllHandles.`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #21914: [hotfix] add warn info to user when NoNodeException happend
Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #21914:
URL: https://github.com/apache/flink/pull/21914#issuecomment-1427547541
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "26ae9f133d74775fd40a1642d7d83a07b11f34c3",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "26ae9f133d74775fd40a1642d7d83a07b11f34c3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 26ae9f133d74775fd40a1642d7d83a07b11f34c3 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] xuzifu666 commented on pull request #21914: [FLINK-31035] add warn info to user when NoNodeException happend
Posted by "xuzifu666 (via GitHub)" <gi...@apache.org>.
xuzifu666 commented on PR #21914:
URL: https://github.com/apache/flink/pull/21914#issuecomment-1427835062
@rkhachatryan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] xuzifu666 closed pull request #21914: [FLINK-31035] add warn info to user when NoNodeException happend
Posted by "xuzifu666 (via GitHub)" <gi...@apache.org>.
xuzifu666 closed pull request #21914: [FLINK-31035] add warn info to user when NoNodeException happend
URL: https://github.com/apache/flink/pull/21914
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rkhachatryan commented on pull request #21914: [FLINK-31035] add warn info to user when NoNodeException happend
Posted by "rkhachatryan (via GitHub)" <gi...@apache.org>.
rkhachatryan commented on PR #21914:
URL: https://github.com/apache/flink/pull/21914#issuecomment-1456656712
As pointed out by @reswqa , there are build failures related to formatting, could you address them @xuzifu666 ?
And there are still several commits in the history, could you please merge everything into one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] xuzifu666 commented on pull request #21914: [FLINK-31035] add warn info to user when NoNodeException happend
Posted by "xuzifu666 (via GitHub)" <gi...@apache.org>.
xuzifu666 commented on PR #21914:
URL: https://github.com/apache/flink/pull/21914#issuecomment-1455393875
@rkhachatryan hi，this pr can be merged？ this message is need where we occur zk leader change to resolve problem
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] xuzifu666 commented on pull request #21914: [hotfix] add warn info to user when NoNodeException happend
Posted by "xuzifu666 (via GitHub)" <gi...@apache.org>.
xuzifu666 commented on PR #21914:
URL: https://github.com/apache/flink/pull/21914#issuecomment-1427566862
> @xuzifu666 Thanks for creating this. Could you explain why it is necessary to print warn-level logs here? Personally, this only happens when the `ZNode` is modified concurrently. The framework will retry itself, and printing the log will make users feel confused.
we offten occur zk leader change when zxid over it's range, get the message can tell us in time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] xuzifu666 commented on pull request #21914: [hotfix] add warn info to user when NoNodeException happend
Posted by "xuzifu666 (via GitHub)" <gi...@apache.org>.
xuzifu666 commented on PR #21914:
URL: https://github.com/apache/flink/pull/21914#issuecomment-1427539886
@reswqa have a review plz，thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] reswqa commented on pull request #21914: [hotfix] add warn info to user when NoNodeException happend
Posted by "reswqa (via GitHub)" <gi...@apache.org>.
reswqa commented on PR #21914:
URL: https://github.com/apache/flink/pull/21914#issuecomment-1427558724
@xuzifu666 Thanks for creating this. Could you explain why it is necessary to print warn-level logs here? Personally, this only happens when the `ZNode` is modified concurrently. The framework will retry itself, and printing the log will make users feel confused.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] xuzifu666 commented on pull request #21914: [FLINK-31035] add warn info to user when NoNodeException happend
Posted by "xuzifu666 (via GitHub)" <gi...@apache.org>.
xuzifu666 commented on PR #21914:
URL: https://github.com/apache/flink/pull/21914#issuecomment-1455980535
> Hi @xuzifu666, could you please squash the commits into one and format the commit message according to [Flink guide](https://flink.apache.org/how-to-contribute/code-style-and-quality-pull-requests/#4-commit-naming-conventions) (similar to the PR title)?
@rkhachatryan ok，thanks，i squash these commits，and commit with the title which is according to guide，can merge now？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org