You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "Hemant Kumar (Jira)" <ji...@apache.org> on 2023/07/17 23:44:00 UTC
[jira] [Comment Edited] (HDDS-7953) [snapshot] SnapshotDiff should throw proper responses in case there are no differences to be listed
[ https://issues.apache.org/jira/browse/HDDS-7953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17743997#comment-17743997 ]
Hemant Kumar edited comment on HDDS-7953 at 7/17/23 11:43 PM:
--------------------------------------------------------------
Regarding second case, It was suggested to not throw an exception instead return empty response.
https://github.com/apache/ozone/pull/4986#issuecomment-1608374872
HDFS does the same:
{code}
[root@rhelnn03 ~]# hdfs snapshotDiff /user/heku snap1 snap1
Difference between snapshot snap1 and snapshot snap1 under directory /user/heku:
[root@rhelnn03 ~]#
{code}
was (Author: JIRAUSER297350):
Regarding second case, It was suggested to not throw an exception instead return empty response.
https://github.com/apache/ozone/pull/4986#issuecomment-1608374872
> [snapshot] SnapshotDiff should throw proper responses in case there are no differences to be listed
> ---------------------------------------------------------------------------------------------------
>
> Key: HDDS-7953
> URL: https://issues.apache.org/jira/browse/HDDS-7953
> Project: Apache Ozone
> Issue Type: Sub-task
> Components: Ozone Manager
> Reporter: Jyotirmoy Sinha
> Assignee: Siyao Meng
> Priority: Major
> Labels: ozone-snapshot
>
> SnapshotDiff should throw proper responses in case there are no differences to be listed
> {code:java}
> [root@jspriv01-1 ~]# ozone sh snapshot snapshotDiff vol1/buck1 snap3 snap4
> Difference between snapshot snap3 and snapshot snap4:
> [root@jspriv01-1 ~]# {code}
> The message for above scenario should indicate that there are no differences in the 2 snapshots
> Also, for a case where the source and destination snapshot are both same, it should throw an error stating that both from-to snapshot cannot be same.
> Current behaviour -
> {code:java}
> [root@jspriv01-1 ~]# ozone sh snapshot snapshotDiff vol1/buck1 snap3 snap3
> Difference between snapshot snap3 and snapshot snap3:
> [root@jspriv01-1 ~] {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org