You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Michael McCandless (JIRA)" <ji...@apache.org> on 2011/05/25 01:44:47 UTC
[jira] [Created] (LUCENE-3140) Backport FSTs to 3.x
Backport FSTs to 3.x
--------------------
Key: LUCENE-3140
URL: https://issues.apache.org/jira/browse/LUCENE-3140
Project: Lucene - Java
Issue Type: Improvement
Reporter: Michael McCandless
Assignee: Michael McCandless
Fix For: 3.2
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Resolved] (LUCENE-3140) Backport FSTs to 3.x
Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael McCandless resolved LUCENE-3140.
----------------------------------------
Resolution: Fixed
Fix Version/s: 4.0
> Backport FSTs to 3.x
> --------------------
>
> Key: LUCENE-3140
> URL: https://issues.apache.org/jira/browse/LUCENE-3140
> Project: Lucene - Java
> Issue Type: Improvement
> Reporter: Michael McCandless
> Assignee: Michael McCandless
> Fix For: 3.2, 4.0
>
> Attachments: LUCENE-3140.patch, LUCENE-3140.patch
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (LUCENE-3140) Backport FSTs to 3.x
Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael McCandless updated LUCENE-3140:
---------------------------------------
Attachment: LUCENE-3140.patch
Initial patch. TestFSTs passes...
I pulled back DataInput/Output too.
Lucene backwards tests failed because IO.copyBytes changed from IndexInput to DataInput...
> Backport FSTs to 3.x
> --------------------
>
> Key: LUCENE-3140
> URL: https://issues.apache.org/jira/browse/LUCENE-3140
> Project: Lucene - Java
> Issue Type: Improvement
> Reporter: Michael McCandless
> Assignee: Michael McCandless
> Fix For: 3.2
>
> Attachments: LUCENE-3140.patch
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-3140) Backport FSTs to 3.x
Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13039177#comment-13039177 ]
Michael McCandless commented on LUCENE-3140:
--------------------------------------------
bq. should we name the thing o.a.l.u.fst in trunk too?
Good idea... I'll do that w/ this issue.
bq. if FST is going to go into 3.x i think we should do a check to ensure all classes are @experimental
OK will do... there were a few missing (I'll fix trunk too).
bq. I think we should consider cutting Builder over to the new CharsRef?
I agree but I think we should do this separately? I'll open an issue...
bq. we need to discuss things like autosuggest file formats, etc? At least so we are all on the same page wrt any backwards policy...
Yes... maybe the same policy as the index? So if you create auto-suggest FST in 3.x, 4.x's suggest module will be able to read it / use it?
The FST itself is already versioned (uses CodecUtil to read/write the header) so we should be all set to impl whatever policy we work out.
> Backport FSTs to 3.x
> --------------------
>
> Key: LUCENE-3140
> URL: https://issues.apache.org/jira/browse/LUCENE-3140
> Project: Lucene - Java
> Issue Type: Improvement
> Reporter: Michael McCandless
> Assignee: Michael McCandless
> Fix For: 3.2
>
> Attachments: LUCENE-3140.patch
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-3140) Backport FSTs to 3.x
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13039106#comment-13039106 ]
Robert Muir commented on LUCENE-3140:
-------------------------------------
Here's just some random stuff I thought about/noticed, some of it only vaguely to this issue:
* should we name the thing o.a.l.u.fst in trunk too?
* if FST is going to go into 3.x i think we should do a check to ensure all classes are @experimental
* I think we should consider cutting Builder over to the new CharsRef?
* we need to discuss things like autosuggest file formats, etc? At least so we are all on the same page wrt any backwards policy...
> Backport FSTs to 3.x
> --------------------
>
> Key: LUCENE-3140
> URL: https://issues.apache.org/jira/browse/LUCENE-3140
> Project: Lucene - Java
> Issue Type: Improvement
> Reporter: Michael McCandless
> Assignee: Michael McCandless
> Fix For: 3.2
>
> Attachments: LUCENE-3140.patch
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (LUCENE-3140) Backport FSTs to 3.x
Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael McCandless updated LUCENE-3140:
---------------------------------------
Attachment: LUCENE-3140.patch
New patch for 3.x. I think it's ready to commit.
I advertised the break of IndexOutput.copyBytes (1st arg now takes DataInput not IndexInput), and remove the backwards test cases that broke from this.
I also added in missing @experimental tags.
> Backport FSTs to 3.x
> --------------------
>
> Key: LUCENE-3140
> URL: https://issues.apache.org/jira/browse/LUCENE-3140
> Project: Lucene - Java
> Issue Type: Improvement
> Reporter: Michael McCandless
> Assignee: Michael McCandless
> Fix For: 3.2
>
> Attachments: LUCENE-3140.patch, LUCENE-3140.patch
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (LUCENE-3140) Backport FSTs to 3.x
Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael McCandless updated LUCENE-3140:
---------------------------------------
Fix Version/s: (was: 3.2)
3.3
> Backport FSTs to 3.x
> --------------------
>
> Key: LUCENE-3140
> URL: https://issues.apache.org/jira/browse/LUCENE-3140
> Project: Lucene - Java
> Issue Type: Improvement
> Reporter: Michael McCandless
> Assignee: Michael McCandless
> Fix For: 3.3, 4.0
>
> Attachments: LUCENE-3140.patch, LUCENE-3140.patch
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-3140) Backport FSTs to 3.x
Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13040797#comment-13040797 ]
Michael McCandless commented on LUCENE-3140:
--------------------------------------------
Committed to 3.x. I still need to move fst under oal.util for trunk...
> Backport FSTs to 3.x
> --------------------
>
> Key: LUCENE-3140
> URL: https://issues.apache.org/jira/browse/LUCENE-3140
> Project: Lucene - Java
> Issue Type: Improvement
> Reporter: Michael McCandless
> Assignee: Michael McCandless
> Fix For: 3.2
>
> Attachments: LUCENE-3140.patch, LUCENE-3140.patch
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org