You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@nifi.apache.org by joewitt <gi...@git.apache.org> on 2016/02/07 21:03:02 UTC
[GitHub] nifi pull request: NIFI-1486 added commons io and lang to nifi-amq...
GitHub user joewitt opened a pull request:
https://github.com/apache/nifi/pull/208
NIFI-1486 added commons io and lang to nifi-amqp-nar NOTICE
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/joewitt/incubator-nifi NIFI-1486
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/208.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #208
----
commit 31694b3a1007a110921653ef5fc4987833d7357a
Author: joewitt <jo...@apache.org>
Date: 2016-02-07T20:01:33Z
NIFI-1486 added commons io and lang to nifi-amqp-nar NOTICE
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-1486 added commons io and lang to nifi-amq...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/208
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-1486 added commons io and lang to nifi-amq...
Posted by olegz <gi...@git.apache.org>.
Github user olegz commented on the pull request:
https://github.com/apache/nifi/pull/208#issuecomment-181098054
Shouldn't it be implied under NiFi since those dependencies are pulled by NiFi dependencies and are not explicitly imported by AMQP NAR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-1486 added commons io and lang to nifi-amq...
Posted by joewitt <gi...@git.apache.org>.
Github user joewitt commented on the pull request:
https://github.com/apache/nifi/pull/208#issuecomment-181099593
regarding the rest of the dependencies they do not exist within the Nar. You have to check the nar itself for what binary dependencies are bundled. We do not need to account for dependencies we are not bundling. Now, those dependencies DO matter in the tar.gz for example which bundles this nar and they are indeed accounted for there.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-1486 added commons io and lang to nifi-amq...
Posted by trkurc <gi...@git.apache.org>.
Github user trkurc commented on the pull request:
https://github.com/apache/nifi/pull/208#issuecomment-181134203
+1 I will merge it in.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-1486 added commons io and lang to nifi-amq...
Posted by joewitt <gi...@git.apache.org>.
Github user joewitt commented on the pull request:
https://github.com/apache/nifi/pull/208#issuecomment-181098506
Nothing is implied. The nar has bundled binary dependencies or it does not. If it does then each of those, regardless of why they are there, need to be accounted for in the LICENSE and NOTICE files as appropriate.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-1486 added commons io and lang to nifi-amq...
Posted by olegz <gi...@git.apache.org>.
Github user olegz commented on the pull request:
https://github.com/apache/nifi/pull/208#issuecomment-181098653
Ok, then what about the rest of the dependencies (i.e., antlr, slf4j etc)? Just trying to understand for the future.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---