You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2013/04/23 02:33:56 UTC
Review Request: Added an optional default value for Option::get().
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10717/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Vinod Kone.
Description
-------
See above.
Diffs
-----
third_party/libprocess/third_party/stout/include/stout/option.hpp d19127cd447f26a44ed0da8071b1a8d168c872ca
Diff: https://reviews.apache.org/r/10717/diff/
Testing
-------
make check
Thanks,
Ben Mahler
Re: Review Request: Added an optional default value for Option::get().
Posted by Ben Mahler <be...@gmail.com>.
> On April 25, 2013, 7:42 p.m., Vinod Kone wrote:
> > third_party/libprocess/third_party/stout/include/stout/option.hpp, line 70
> > <https://reviews.apache.org/r/10717/diff/1/?file=283279#file283279line70>
> >
> > s/t/*t/ ?
Good catch, wonder how this compiled..
- Ben
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10717/#review19720
-----------------------------------------------------------
On April 25, 2013, 9:51 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10717/
> -----------------------------------------------------------
>
> (Updated April 25, 2013, 9:51 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Description
> -------
>
> See above.
>
>
> Diffs
> -----
>
> third_party/libprocess/third_party/stout/include/stout/option.hpp d19127cd447f26a44ed0da8071b1a8d168c872ca
>
> Diff: https://reviews.apache.org/r/10717/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request: Added an optional default value for Option::get().
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10717/#review19720
-----------------------------------------------------------
third_party/libprocess/third_party/stout/include/stout/option.hpp
<https://reviews.apache.org/r/10717/#comment40663>
s/t/*t/ ?
- Vinod Kone
On April 23, 2013, 12:33 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10717/
> -----------------------------------------------------------
>
> (Updated April 23, 2013, 12:33 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Description
> -------
>
> See above.
>
>
> Diffs
> -----
>
> third_party/libprocess/third_party/stout/include/stout/option.hpp d19127cd447f26a44ed0da8071b1a8d168c872ca
>
> Diff: https://reviews.apache.org/r/10717/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request: Added an optional default value for Option::get().
Posted by Benjamin Hindman <be...@berkeley.edu>.
> On April 29, 2013, 5:13 p.m., Benjamin Hindman wrote:
> > Ship It!
Also, if you know of places in the code base that can already benefit from this, please make those changes. It's more likely people will use this if/when they see examples in the code.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10717/#review19867
-----------------------------------------------------------
On April 25, 2013, 9:51 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10717/
> -----------------------------------------------------------
>
> (Updated April 25, 2013, 9:51 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Description
> -------
>
> See above.
>
>
> Diffs
> -----
>
> third_party/libprocess/third_party/stout/include/stout/option.hpp d19127cd447f26a44ed0da8071b1a8d168c872ca
>
> Diff: https://reviews.apache.org/r/10717/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request: Added an optional default value for Option::get().
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10717/#review19867
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Hindman
On April 25, 2013, 9:51 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10717/
> -----------------------------------------------------------
>
> (Updated April 25, 2013, 9:51 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Description
> -------
>
> See above.
>
>
> Diffs
> -----
>
> third_party/libprocess/third_party/stout/include/stout/option.hpp d19127cd447f26a44ed0da8071b1a8d168c872ca
>
> Diff: https://reviews.apache.org/r/10717/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request: Added an optional default value for Option::get().
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10717/
-----------------------------------------------------------
(Updated April 25, 2013, 9:51 p.m.)
Review request for mesos, Benjamin Hindman and Vinod Kone.
Changes
-------
Vinod's review.
Description
-------
See above.
Diffs (updated)
-----
third_party/libprocess/third_party/stout/include/stout/option.hpp d19127cd447f26a44ed0da8071b1a8d168c872ca
Diff: https://reviews.apache.org/r/10717/diff/
Testing
-------
make check
Thanks,
Ben Mahler