You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Jonathan Ellis (JIRA)" <ji...@apache.org> on 2010/01/25 20:05:34 UTC

[jira] Created: (CASSANDRA-736) time to add first-class thrift methods for the string meta queries?

time to add first-class thrift methods for the string meta queries?
-------------------------------------------------------------------

                 Key: CASSANDRA-736
                 URL: https://issues.apache.org/jira/browse/CASSANDRA-736
             Project: Cassandra
          Issue Type: New Feature
          Components: Tools
            Reporter: Jonathan Ellis
            Priority: Minor
             Fix For: 0.6


I'd like to add these with a c_ (or system_? or meta_?) prefix, to make clear that clients who just want to insert and update stuff don't need to care about it.

currently get_string_property provides
"cluster name"
"config file" [I think we should get rid of this one]
"token map"
"version"

get_string_list_property provides
"keyspaces"


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-736) time to add first-class thrift methods for the string meta queries?

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-736?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Ellis updated CASSANDRA-736:
-------------------------------------

    Attachment: 736.txt

> time to add first-class thrift methods for the string meta queries?
> -------------------------------------------------------------------
>
>                 Key: CASSANDRA-736
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-736
>             Project: Cassandra
>          Issue Type: New Feature
>          Components: Tools
>            Reporter: Jonathan Ellis
>            Assignee: Jonathan Ellis
>            Priority: Minor
>             Fix For: 0.6
>
>         Attachments: 736.txt
>
>
> I'd like to add these with a c_ (or system_? or meta_?) prefix, to make clear that clients who just want to insert and update stuff don't need to care about it.
> currently get_string_property provides
> "cluster name"
> "config file" [I think we should get rid of this one]
> "token map"
> "version"
> get_string_list_property provides
> "keyspaces"

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (CASSANDRA-736) time to add first-class thrift methods for the string meta queries?

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-736?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Ellis reassigned CASSANDRA-736:
----------------------------------------

    Assignee: Jonathan Ellis  (was: Eric Evans)

> time to add first-class thrift methods for the string meta queries?
> -------------------------------------------------------------------
>
>                 Key: CASSANDRA-736
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-736
>             Project: Cassandra
>          Issue Type: New Feature
>          Components: Tools
>            Reporter: Jonathan Ellis
>            Assignee: Jonathan Ellis
>            Priority: Minor
>             Fix For: 0.6
>
>
> I'd like to add these with a c_ (or system_? or meta_?) prefix, to make clear that clients who just want to insert and update stuff don't need to care about it.
> currently get_string_property provides
> "cluster name"
> "config file" [I think we should get rid of this one]
> "token map"
> "version"
> get_string_list_property provides
> "keyspaces"

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CASSANDRA-736) time to add first-class thrift methods for the string meta queries?

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12806871#action_12806871 ] 

Jonathan Ellis commented on CASSANDRA-736:
------------------------------------------

To me having real methods with real docstrings and real return types (json-encoded token map? seriously?) is so clearly better that I think the onus is on you to give a motivation for NOT doing it. :)

> time to add first-class thrift methods for the string meta queries?
> -------------------------------------------------------------------
>
>                 Key: CASSANDRA-736
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-736
>             Project: Cassandra
>          Issue Type: New Feature
>          Components: Tools
>            Reporter: Jonathan Ellis
>            Assignee: Eric Evans
>            Priority: Minor
>             Fix For: 0.6
>
>
> I'd like to add these with a c_ (or system_? or meta_?) prefix, to make clear that clients who just want to insert and update stuff don't need to care about it.
> currently get_string_property provides
> "cluster name"
> "config file" [I think we should get rid of this one]
> "token map"
> "version"
> get_string_list_property provides
> "keyspaces"

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CASSANDRA-736) time to add first-class thrift methods for the string meta queries?

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12804651#action_12804651 ] 

Jonathan Ellis commented on CASSANDRA-736:
------------------------------------------

I could see "keyspaces" moving to get_keyspaces (rather than system_keyspaces), especially since CASSANDRA-44 is getting closer

> time to add first-class thrift methods for the string meta queries?
> -------------------------------------------------------------------
>
>                 Key: CASSANDRA-736
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-736
>             Project: Cassandra
>          Issue Type: New Feature
>          Components: Tools
>            Reporter: Jonathan Ellis
>            Priority: Minor
>             Fix For: 0.6
>
>
> I'd like to add these with a c_ (or system_? or meta_?) prefix, to make clear that clients who just want to insert and update stuff don't need to care about it.
> currently get_string_property provides
> "cluster name"
> "config file" [I think we should get rid of this one]
> "token map"
> "version"
> get_string_list_property provides
> "keyspaces"

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (CASSANDRA-736) time to add first-class thrift methods for the string meta queries?

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-736?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Ellis reassigned CASSANDRA-736:
----------------------------------------

    Assignee: Eric Evans

> time to add first-class thrift methods for the string meta queries?
> -------------------------------------------------------------------
>
>                 Key: CASSANDRA-736
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-736
>             Project: Cassandra
>          Issue Type: New Feature
>          Components: Tools
>            Reporter: Jonathan Ellis
>            Assignee: Eric Evans
>            Priority: Minor
>             Fix For: 0.6
>
>
> I'd like to add these with a c_ (or system_? or meta_?) prefix, to make clear that clients who just want to insert and update stuff don't need to care about it.
> currently get_string_property provides
> "cluster name"
> "config file" [I think we should get rid of this one]
> "token map"
> "version"
> get_string_list_property provides
> "keyspaces"

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-736) time to add first-class thrift methods for the string meta queries?

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-736?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Ellis updated CASSANDRA-736:
-------------------------------------

    Attachment: 736.txt

> time to add first-class thrift methods for the string meta queries?
> -------------------------------------------------------------------
>
>                 Key: CASSANDRA-736
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-736
>             Project: Cassandra
>          Issue Type: New Feature
>          Components: Tools
>            Reporter: Jonathan Ellis
>            Assignee: Jonathan Ellis
>            Priority: Minor
>             Fix For: 0.6
>
>         Attachments: 736.txt
>
>
> I'd like to add these with a c_ (or system_? or meta_?) prefix, to make clear that clients who just want to insert and update stuff don't need to care about it.
> currently get_string_property provides
> "cluster name"
> "config file" [I think we should get rid of this one]
> "token map"
> "version"
> get_string_list_property provides
> "keyspaces"

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Issue Comment Edited: (CASSANDRA-736) time to add first-class thrift methods for the string meta queries?

Posted by "Stu Hood (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12830806#action_12830806 ] 

Stu Hood edited comment on CASSANDRA-736 at 2/8/10 1:28 AM:
------------------------------------------------------------

> the ranges are represent as a comma-separated string of left_token, right_token
This won't work for OPP, since StringToken may contain commas. To get around the Thrift map restriction, you could use a list of key-value pairs instead? Also, you may want to just treat tokens as opaque binaries.

EDIT: Nevermind about treating tokens as binaries... that would not be very friendly for client side debugging.

      was (Author: stuhood):
    > the ranges are represent as a comma-separated string of left_token, right_token
This won't work for OPP, since StringToken may contain commas. To get around the Thrift map restriction, you could use a list of key-value pairs instead? Also, you may want to just treat tokens as opaque binaries.
  
> time to add first-class thrift methods for the string meta queries?
> -------------------------------------------------------------------
>
>                 Key: CASSANDRA-736
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-736
>             Project: Cassandra
>          Issue Type: New Feature
>          Components: Tools
>            Reporter: Jonathan Ellis
>            Assignee: Jonathan Ellis
>            Priority: Minor
>             Fix For: 0.6
>
>         Attachments: 736.txt
>
>
> I'd like to add these with a c_ (or system_? or meta_?) prefix, to make clear that clients who just want to insert and update stuff don't need to care about it.
> currently get_string_property provides
> "cluster name"
> "config file" [I think we should get rid of this one]
> "token map"
> "version"
> get_string_list_property provides
> "keyspaces"

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CASSANDRA-736) time to add first-class thrift methods for the string meta queries?

Posted by "Stu Hood (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12830806#action_12830806 ] 

Stu Hood commented on CASSANDRA-736:
------------------------------------

> the ranges are represent as a comma-separated string of left_token, right_token
This won't work for OPP, since StringToken may contain commas. To get around the Thrift map restriction, you could use a list of key-value pairs instead? Also, you may want to just treat tokens as opaque binaries.

> time to add first-class thrift methods for the string meta queries?
> -------------------------------------------------------------------
>
>                 Key: CASSANDRA-736
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-736
>             Project: Cassandra
>          Issue Type: New Feature
>          Components: Tools
>            Reporter: Jonathan Ellis
>            Assignee: Jonathan Ellis
>            Priority: Minor
>             Fix For: 0.6
>
>         Attachments: 736.txt
>
>
> I'd like to add these with a c_ (or system_? or meta_?) prefix, to make clear that clients who just want to insert and update stuff don't need to care about it.
> currently get_string_property provides
> "cluster name"
> "config file" [I think we should get rid of this one]
> "token map"
> "version"
> get_string_list_property provides
> "keyspaces"

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-736) time to add first-class thrift methods for the string meta queries?

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-736?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Ellis updated CASSANDRA-736:
-------------------------------------

    Attachment:     (was: 736.txt)

> time to add first-class thrift methods for the string meta queries?
> -------------------------------------------------------------------
>
>                 Key: CASSANDRA-736
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-736
>             Project: Cassandra
>          Issue Type: New Feature
>          Components: Tools
>            Reporter: Jonathan Ellis
>            Assignee: Jonathan Ellis
>            Priority: Minor
>             Fix For: 0.6
>
>         Attachments: 736.txt
>
>
> I'd like to add these with a c_ (or system_? or meta_?) prefix, to make clear that clients who just want to insert and update stuff don't need to care about it.
> currently get_string_property provides
> "cluster name"
> "config file" [I think we should get rid of this one]
> "token map"
> "version"
> get_string_list_property provides
> "keyspaces"

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CASSANDRA-736) time to add first-class thrift methods for the string meta queries?

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12834877#action_12834877 ] 

Hudson commented on CASSANDRA-736:
----------------------------------

Integrated in Cassandra #357 (See [http://hudson.zones.apache.org/hudson/job/Cassandra/357/])
    

> time to add first-class thrift methods for the string meta queries?
> -------------------------------------------------------------------
>
>                 Key: CASSANDRA-736
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-736
>             Project: Cassandra
>          Issue Type: New Feature
>          Components: Tools
>            Reporter: Jonathan Ellis
>            Assignee: Jonathan Ellis
>            Priority: Minor
>             Fix For: 0.6
>
>         Attachments: 736.txt
>
>
> I'd like to add these with a c_ (or system_? or meta_?) prefix, to make clear that clients who just want to insert and update stuff don't need to care about it.
> currently get_string_property provides
> "cluster name"
> "config file" [I think we should get rid of this one]
> "token map"
> "version"
> get_string_list_property provides
> "keyspaces"

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CASSANDRA-736) time to add first-class thrift methods for the string meta queries?

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12830811#action_12830811 ] 

Jonathan Ellis commented on CASSANDRA-736:
------------------------------------------

Actually my first version of this had binary tokens but as you say there's not much upside for the pain it causes.

I'll rework to use lists of pairs.  #@!$# thrift.

> time to add first-class thrift methods for the string meta queries?
> -------------------------------------------------------------------
>
>                 Key: CASSANDRA-736
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-736
>             Project: Cassandra
>          Issue Type: New Feature
>          Components: Tools
>            Reporter: Jonathan Ellis
>            Assignee: Jonathan Ellis
>            Priority: Minor
>             Fix For: 0.6
>
>         Attachments: 736.txt
>
>
> I'd like to add these with a c_ (or system_? or meta_?) prefix, to make clear that clients who just want to insert and update stuff don't need to care about it.
> currently get_string_property provides
> "cluster name"
> "config file" [I think we should get rid of this one]
> "token map"
> "version"
> get_string_list_property provides
> "keyspaces"

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-736) time to add first-class thrift methods for the string meta queries?

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-736?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Ellis updated CASSANDRA-736:
-------------------------------------

    Attachment: 736.txt

> time to add first-class thrift methods for the string meta queries?
> -------------------------------------------------------------------
>
>                 Key: CASSANDRA-736
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-736
>             Project: Cassandra
>          Issue Type: New Feature
>          Components: Tools
>            Reporter: Jonathan Ellis
>            Assignee: Jonathan Ellis
>            Priority: Minor
>             Fix For: 0.6
>
>         Attachments: 736.txt
>
>
> I'd like to add these with a c_ (or system_? or meta_?) prefix, to make clear that clients who just want to insert and update stuff don't need to care about it.
> currently get_string_property provides
> "cluster name"
> "config file" [I think we should get rid of this one]
> "token map"
> "version"
> get_string_list_property provides
> "keyspaces"

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CASSANDRA-736) time to add first-class thrift methods for the string meta queries?

Posted by "Ryan King (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12806842#action_12806842 ] 

Ryan King commented on CASSANDRA-736:
-------------------------------------

What's the motivation for this?

> time to add first-class thrift methods for the string meta queries?
> -------------------------------------------------------------------
>
>                 Key: CASSANDRA-736
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-736
>             Project: Cassandra
>          Issue Type: New Feature
>          Components: Tools
>            Reporter: Jonathan Ellis
>            Assignee: Eric Evans
>            Priority: Minor
>             Fix For: 0.6
>
>
> I'd like to add these with a c_ (or system_? or meta_?) prefix, to make clear that clients who just want to insert and update stuff don't need to care about it.
> currently get_string_property provides
> "cluster name"
> "config file" [I think we should get rid of this one]
> "token map"
> "version"
> get_string_list_property provides
> "keyspaces"

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-736) time to add first-class thrift methods for the string meta queries?

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-736?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Ellis updated CASSANDRA-736:
-------------------------------------

    Attachment:     (was: 736.txt)

> time to add first-class thrift methods for the string meta queries?
> -------------------------------------------------------------------
>
>                 Key: CASSANDRA-736
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-736
>             Project: Cassandra
>          Issue Type: New Feature
>          Components: Tools
>            Reporter: Jonathan Ellis
>            Assignee: Jonathan Ellis
>            Priority: Minor
>             Fix For: 0.6
>
>         Attachments: 736.txt
>
>
> I'd like to add these with a c_ (or system_? or meta_?) prefix, to make clear that clients who just want to insert and update stuff don't need to care about it.
> currently get_string_property provides
> "cluster name"
> "config file" [I think we should get rid of this one]
> "token map"
> "version"
> get_string_list_property provides
> "keyspaces"

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.