You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/01/29 20:00:14 UTC
[GitHub] [incubator-nuttx] ppisa opened a new pull request #2779: arch/arm/src/samv7/sam_mcan.c: fix some mismatches caused by renaming.
ppisa opened a new pull request #2779:
URL: https://github.com/apache/incubator-nuttx/pull/2779
## Summary
The MCAN driver private structure has been renamed to struct sam_mcan_s,
but some functions reference sam_can_s. There are missing defines
of return variable in some functions.
## Impact
## Testing
No testing we do not have evaluation kit nor own device based on SAM7 yet.
But it is in purchase. We need functional CAN and CAN FD support.
If there is somebody who can test the driver or used it on older NuttX version
before compile break by rename it would be great.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #2779: arch/arm/src/samv7/sam_mcan.c: fix some mismatches caused by renaming.
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #2779:
URL: https://github.com/apache/incubator-nuttx/pull/2779
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #2779: arch/arm/src/samv7/sam_mcan.c: fix some mismatches caused by renaming.
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #2779:
URL: https://github.com/apache/incubator-nuttx/pull/2779#issuecomment-771303476
LGTM.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] ppisa commented on pull request #2779: arch/arm/src/samv7/sam_mcan.c: fix some mismatches caused by renaming.
Posted by GitBox <gi...@apache.org>.
ppisa commented on pull request #2779:
URL: https://github.com/apache/incubator-nuttx/pull/2779#issuecomment-771270675
The fix is updated. I have even cleaned up all build warnings for my config.
There caa be problems that CAN message fields typed change for case when extended ID is supported etc. I tried to make code clean for all/the most of the variants but not tested all build.
Code not tested on the hardware but colleagues form Elektroline company are buying kit and I would be happy if they could start directly from mainline without (at least) build errors.
Best wishes,
Pavel
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #2779: arch/arm/src/samv7/sam_mcan.c: fix some mismatches caused by renaming.
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #2779:
URL: https://github.com/apache/incubator-nuttx/pull/2779#issuecomment-771303476
LGTM.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #2779: arch/arm/src/samv7/sam_mcan.c: fix some mismatches caused by renaming.
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #2779:
URL: https://github.com/apache/incubator-nuttx/pull/2779
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] ppisa commented on pull request #2779: arch/arm/src/samv7/sam_mcan.c: fix some mismatches caused by renaming.
Posted by GitBox <gi...@apache.org>.
ppisa commented on pull request #2779:
URL: https://github.com/apache/incubator-nuttx/pull/2779#issuecomment-771270675
The fix is updated. I have even cleaned up all build warnings for my config.
There caa be problems that CAN message fields typed change for case when extended ID is supported etc. I tried to make code clean for all/the most of the variants but not tested all build.
Code not tested on the hardware but colleagues form Elektroline company are buying kit and I would be happy if they could start directly from mainline without (at least) build errors.
Best wishes,
Pavel
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #2779: arch/arm/src/samv7/sam_mcan.c: fix some mismatches caused by renaming.
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #2779:
URL: https://github.com/apache/incubator-nuttx/pull/2779#issuecomment-770159360
@ppisa could you fix the follow nxstyle warning:
```
Error: /home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/arch/arm/src/samv7/sam_mcan.c:1574:78: error: Long line found
Error: /home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/arch/arm/src/samv7/sam_mcan.c:3427:79: error: Long line found
```
Your change doesn't introduce more warning, but the community agree that the contributor has to help fix the warning.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org