You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tamaya.apache.org by "John D. Ament" <jo...@apache.org> on 2016/04/16 16:42:22 UTC
Why depend on Arquillian?
All,
Going through the notices issue still. I wonder, why do we declare a
dependency on arquillian/shrinkwrap? We have a single test which is
ignored that uses it, and I'm not sure what the aim is TBH.
https://github.com/apache/incubator-tamaya/blob/master/modules/integration/osgi/src/test/java/org/apache/tamaya/integration/osgi/TestConfigIntegration.java
So can we kill this test and the dependency? Probably not, since its the
only test in that module. So how do we test OSGi?
John
Re: Why depend on Arquillian?
Posted by "John D. Ament" <jo...@apache.org>.
Ok, so I'll have to pick back up tomorrow/later this week.
I have a few questions about what this test is intending to do.
1. What is the scope of testing for this module? Are we testing OSGi
support for core or everything?
2. Why does it have so many dependencies? It seems like it declares things
like CDI, interceptor, etc but doesn't use them. Though I may be
misunderstanding it.
3. Should we perhaps have tests within various modules to make sure that
module works with OSGi?
You can see where I'm at right now here:
https://gist.github.com/johnament/0c4867aabad8410fdd0b230261558cb8
John
On Sat, Apr 16, 2016 at 10:55 AM John D. Ament <jo...@apache.org>
wrote:
> Looks like the test was depending on the JARs included in the source code,
> which were removed in the release process. I can try to spend some time on
> it.
>
> John
>
>
> On Sat, Apr 16, 2016 at 10:48 AM Anatole Tresch <at...@gmail.com>
> wrote:
>
>> Hi
>>
>> It should only be a test dependency, not for production or distribution ;)
>>
>> The test once worked, but stopped working again (dont ask me why). It
>> would
>> be good if someone with more arquillian know how can get it up again.
>> For me all the OSGI support is quite costly in terms of time, so I stopped
>> to invest more into it.
>>
>>
>>
>>
>> 2016-04-16 16:42 GMT+02:00 John D. Ament <jo...@apache.org>:
>>
>> > All,
>> >
>> > Going through the notices issue still. I wonder, why do we declare a
>> > dependency on arquillian/shrinkwrap? We have a single test which is
>> > ignored that uses it, and I'm not sure what the aim is TBH.
>> >
>> >
>> >
>> https://github.com/apache/incubator-tamaya/blob/master/modules/integration/osgi/src/test/java/org/apache/tamaya/integration/osgi/TestConfigIntegration.java
>> >
>> > So can we kill this test and the dependency? Probably not, since its
>> the
>> > only test in that module. So how do we test OSGi?
>> >
>> > John
>> >
>>
>>
>>
>> --
>> *Anatole Tresch*
>> Java Engineer & Architect, JCP Star Spec Lead
>> *Switzerland, Europe Zurich, GMT+1*
>>
>> *Blogs: **http://maketechsimple.wordpress.com
>> <http://maketechsimple.wordpress.com/> *
>> *Twitter: @atsticks*
>>
>
Re: Why depend on Arquillian?
Posted by "John D. Ament" <jo...@apache.org>.
Looks like the test was depending on the JARs included in the source code,
which were removed in the release process. I can try to spend some time on
it.
John
On Sat, Apr 16, 2016 at 10:48 AM Anatole Tresch <at...@gmail.com> wrote:
> Hi
>
> It should only be a test dependency, not for production or distribution ;)
>
> The test once worked, but stopped working again (dont ask me why). It would
> be good if someone with more arquillian know how can get it up again.
> For me all the OSGI support is quite costly in terms of time, so I stopped
> to invest more into it.
>
>
>
>
> 2016-04-16 16:42 GMT+02:00 John D. Ament <jo...@apache.org>:
>
> > All,
> >
> > Going through the notices issue still. I wonder, why do we declare a
> > dependency on arquillian/shrinkwrap? We have a single test which is
> > ignored that uses it, and I'm not sure what the aim is TBH.
> >
> >
> >
> https://github.com/apache/incubator-tamaya/blob/master/modules/integration/osgi/src/test/java/org/apache/tamaya/integration/osgi/TestConfigIntegration.java
> >
> > So can we kill this test and the dependency? Probably not, since its the
> > only test in that module. So how do we test OSGi?
> >
> > John
> >
>
>
>
> --
> *Anatole Tresch*
> Java Engineer & Architect, JCP Star Spec Lead
> *Switzerland, Europe Zurich, GMT+1*
>
> *Blogs: **http://maketechsimple.wordpress.com
> <http://maketechsimple.wordpress.com/> *
> *Twitter: @atsticks*
>
Re: Why depend on Arquillian?
Posted by Anatole Tresch <at...@gmail.com>.
Hi
It should only be a test dependency, not for production or distribution ;)
The test once worked, but stopped working again (dont ask me why). It would
be good if someone with more arquillian know how can get it up again.
For me all the OSGI support is quite costly in terms of time, so I stopped
to invest more into it.
2016-04-16 16:42 GMT+02:00 John D. Ament <jo...@apache.org>:
> All,
>
> Going through the notices issue still. I wonder, why do we declare a
> dependency on arquillian/shrinkwrap? We have a single test which is
> ignored that uses it, and I'm not sure what the aim is TBH.
>
>
> https://github.com/apache/incubator-tamaya/blob/master/modules/integration/osgi/src/test/java/org/apache/tamaya/integration/osgi/TestConfigIntegration.java
>
> So can we kill this test and the dependency? Probably not, since its the
> only test in that module. So how do we test OSGi?
>
> John
>
--
*Anatole Tresch*
Java Engineer & Architect, JCP Star Spec Lead
*Switzerland, Europe Zurich, GMT+1*
*Blogs: **http://maketechsimple.wordpress.com
<http://maketechsimple.wordpress.com/> *
*Twitter: @atsticks*