You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/05/24 13:14:43 UTC

[GitHub] [tvm] giuseros edited a comment on pull request #8014: [AOT] Name mangling in AOT

giuseros edited a comment on pull request #8014:
URL: https://github.com/apache/tvm/pull/8014#issuecomment-847034194


   Hi @manupa-arm , 
   Thanks for your reply. I pushed a new set of changes trying to address your comments:
   * Now I am using name-mangling as default in all TVM, removing duplication for non-mangled behaviour. 
   * The `MangleGraph` pass is now the default in the partitioning pipeline
   * The mangled mod-name is formed in python and passed down in C++ where we only concatenate to the function names
   
   I guess that, in addition to make the tests pass, we need to agree on naming:
   * `MangleGraph`. Is `MangleExternalFunction` better? Because I am only mangling the functions that will be offloaded to the external compiler
   * `run_func`: is it ok for everyone if I use only `run`? My problem with only `run` is that it seems a bit too generic. Maybe `run_model`? What do you think?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org