You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/04/29 20:38:51 UTC

[GitHub] [arrow] westonpace commented on a diff in pull request #13035: ARROW-16419: [Python] Properly wait for ExecPlan to finish

westonpace commented on code in PR #13035:
URL: https://github.com/apache/arrow/pull/13035#discussion_r862135947


##########
python/pyarrow/includes/libarrow.pxd:
##########
@@ -81,6 +81,11 @@ cdef extern from "arrow/config.h" namespace "arrow" nogil:
     CRuntimeInfo GetRuntimeInfo()
 
 
+cdef extern from "arrow/util/future.h" namespace "arrow" nogil:
+    cdef cppclass CFuture_Void" arrow::Future<>":
+        CStatus status()

Review Comment:
   Surprising we've made it this far without exposing `Future`.  I wonder if we want to add a `WaitForFinish` method on ExecPlan instead of exposing `Future` (essentially a sync mirror-api) like we do in the `Scanner`.
   
   I don't really have any problems with this approach though.  Just making an observation.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org