You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@phoenix.apache.org by "Hudson (JIRA)" <ji...@apache.org> on 2015/12/31 04:00:54 UTC

[jira] [Commented] (PHOENIX-2453) Make prepared statement creation delegate to org.apache.phoenix.jdbc.PhoenixConnection#prepareStatement(java.lang.String)

    [ https://issues.apache.org/jira/browse/PHOENIX-2453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15075666#comment-15075666 ] 

Hudson commented on PHOENIX-2453:
---------------------------------

FAILURE: Integrated in Phoenix-master #1038 (See [https://builds.apache.org/job/Phoenix-master/1038/])
PHOENIX-2453 Make prepared statement creation delegate to (jtaylor: rev ba77397bbf64a9fad6e231d64d10e9c56d01adc0)
* phoenix-core/src/test/java/org/apache/phoenix/jdbc/PhoenixPreparedStatementTest.java
* phoenix-core/src/main/java/org/apache/phoenix/jdbc/PhoenixStatement.java
* phoenix-core/src/main/java/org/apache/phoenix/jdbc/PhoenixConnection.java


> Make prepared statement creation delegate to org.apache.phoenix.jdbc.PhoenixConnection#prepareStatement(java.lang.String)
> -------------------------------------------------------------------------------------------------------------------------
>
>                 Key: PHOENIX-2453
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-2453
>             Project: Phoenix
>          Issue Type: Improvement
>    Affects Versions: 4.5.2
>            Reporter: Clement Escoffier
>            Assignee: Clement Escoffier
>             Fix For: 4.7.0
>
>         Attachments: PHOENIX-2453.patch
>
>
> This issue is about making the prepare statement creation methods delegate to org.apache.phoenix.jdbc.PhoenixConnection#prepareStatement(java.lang.String) in order to avoid exception in applications and clients using this method.
> For the context, the issue was raised by a user of vert.x (http://vertx.io). This user tries to connect the vertx-jdbc-client to phoenix. A vert.x application cannot use directly the JDBC driver because it promotes an asynchronous and non-blocking development model (while jdbc interactions are blocking). The vertx-jdbc-client is using ` `prepareStatement(String sql, int autoGeneratedKeys)` which throws an exception. 
> A solution would be to delegate the method to the "simplest" version (just "sql") and ignore the effect of the passed parameter.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)