You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Graham Wallis <gr...@uk.ibm.com> on 2018/04/10 09:01:36 UTC
Review Request 66522: ATLAS-2523: RelationshipStore accepts existing
GUID
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66522/
-----------------------------------------------------------
Review request for atlas.
Repository: atlas
Description
-------
ATLAS-2523: RelationshipStore accepts existing GUID
Diffs
-----
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipStoreV1.java 28636d864f28aea97ae50683a84b79a2b29cd166
Diff: https://reviews.apache.org/r/66522/diff/1/
Testing
-------
During connector development I have been saving relationships with externally specified GUIDs from FV tests.
Thanks,
Graham Wallis
Re: Review Request 66522: ATLAS-2523: RelationshipStore accepts
existing GUID
Posted by David Radley <da...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66522/#review200802
-----------------------------------------------------------
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipStoreV1.java
Lines 570 (patched)
<https://reviews.apache.org/r/66522/#comment281692>
For the open metadata usage - would it not be better to accept any value for the guid - rather than restricting it to the the Atlas format. I assume the archive type guids are of this form, but what about a relationship type that is mastered in another repository, this may not conform to the Atlas format for guids.
In the Entity case the IGC RID may not conform to an assigned or unassigned Atlas guid.
I think we need to consistent in how we treat the relationship and entity type guids - and not enforce the Atlas format on supplied guids - as they are likely to not match the Atlas format.
- David Radley
On April 10, 2018, 9:01 a.m., Graham Wallis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66522/
> -----------------------------------------------------------
>
> (Updated April 10, 2018, 9:01 a.m.)
>
>
> Review request for atlas.
>
>
> Repository: atlas
>
>
> Description
> -------
>
> ATLAS-2523: RelationshipStore accepts existing GUID
>
>
> Diffs
> -----
>
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipStoreV1.java 28636d864f28aea97ae50683a84b79a2b29cd166
>
>
> Diff: https://reviews.apache.org/r/66522/diff/1/
>
>
> Testing
> -------
>
> During connector development I have been saving relationships with externally specified GUIDs from FV tests.
>
>
> Thanks,
>
> Graham Wallis
>
>