[GitHub] [spark] AngersZhuuuu commented on a change in pull request #29909: [SPARK-33023][CORE] Judge path of Windows need add condition `Utils.isWindows`

[GitBox <gi...@apache.org>]

AngersZhuuuu commented on a change in pull request #29909:
URL: https://github.com/apache/spark/pull/29909#discussion_r497951985



##########
File path: core/src/main/scala/org/apache/spark/SparkContext.scala
##########
@@ -1899,7 +1899,7 @@ class SparkContext(config: SparkConf) extends Logging {
     if (path == null || path.isEmpty) {
       logWarning("null or empty path specified as parameter to addJar")
     } else {
-      val key = if (path.contains("\\")) {
+      val key = if (path.contains("\\") && Utils.isWindows) {

Review comment:
       > @AngersZhuuuu . This is `CORE` instead of `SQL`.
   > 
   > * `core/src/main/scala/org/apache/spark/SparkContext.scala`
   
   Sorry, since always work at `SQL`  module




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org