You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by akag98 <gi...@git.apache.org> on 2018/09/12 14:09:17 UTC
[GitHub] tomcat pull request #121: restart.bat
GitHub user akag98 opened a pull request:
https://github.com/apache/tomcat/pull/121
restart.bat
Bat file that calls shutdown.bat and then startup.bat to restart the server.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/akag98/tomcat patch-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tomcat/pull/121.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #121
----
commit fb0c22e07acfa92b3c22942563478db02cc90e35
Author: akag98 <38...@...>
Date: 2018-09-12T14:05:31Z
restart.bat
Bat file that calls shutdown.bat and then startup.bat to restart the server.
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] tomcat issue #121: restart.bat
Posted by kkolinko <gi...@git.apache.org>.
Github user kkolinko commented on the issue:
https://github.com/apache/tomcat/pull/121
1. This does not conform to code style. The "echo off" command and license header are missing.
2. This approach is naive and does not work. The "shutdown.bat" script does not stop Tomcat! It just commands Tomcat to stop. The shutting down may take some time.
3. A rather rare use case.
If one is developing, I think an IDE should know how restart Tomcat (e.g. Eclipse IDE knows how to do it and how to stop Tomcat process forcefully if it does not shut down in time).
Thus I am -1 on merging this.
4. IMHO, the proper place to file enhancement requests is Bugzilla, so that they can be referenced in changelog.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] tomcat pull request #121: restart.bat
Posted by akag98 <gi...@git.apache.org>.
Github user akag98 closed the pull request at:
https://github.com/apache/tomcat/pull/121
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] tomcat issue #121: restart.bat
Posted by akag98 <gi...@git.apache.org>.
Github user akag98 commented on the issue:
https://github.com/apache/tomcat/pull/121
Thanks @isapir for your review.
I will surely look into that.
Thanks :)
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] tomcat issue #121: restart.bat
Posted by akag98 <gi...@git.apache.org>.
Github user akag98 commented on the issue:
https://github.com/apache/tomcat/pull/121
Thanks @kkolinko for your review...
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] tomcat issue #121: restart.bat
Posted by isapir <gi...@git.apache.org>.
Github user isapir commented on the issue:
https://github.com/apache/tomcat/pull/121
While I like the idea of adding an easy way to restart, I'd prefer to add a switch to startup rather than add a new script just for that, e.g. `startup -restart` or `catalina restart`.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org