You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by liu-zhaokun <gi...@git.apache.org> on 2017/03/08 06:32:31 UTC
[GitHub] storm pull request #1992: [STORM-2397] modify storm-kafka.md
GitHub user liu-zhaokun opened a pull request:
https://github.com/apache/storm/pull/1992
[STORM-2397] modify storm-kafka.md
[https://issues.apache.org/jira/browse/STORM-2397](url)
KafkaBolt doesn't have a static variable named "KAFKA_BROKER_PROPERTIES" in storm 1.0.2.So storm-kafka.md should be modified as the patch.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/liu-zhaokun/storm-windows 1.0.x-branch
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/1992.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1992
----
commit 9e0cddfd8a3c9b49f3dbb1cb00f5085b9ab01b22
Author: liuzhaokun <li...@zte.com.cn>
Date: 2017-03-08T06:30:57Z
[STORM-2397] modify storm-kafka.md
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1992: [STORM-2397] modify storm-kafka.md
Posted by liu-zhaokun <gi...@git.apache.org>.
Github user liu-zhaokun commented on the issue:
https://github.com/apache/storm/pull/1992
@HeartSaVioR
But the website [has](http://storm.apache.org/releases/1.0.2/storm-kafka.html) not been modified.My issues aim at modifying the website about storm 1.0.2.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1992: [STORM-2397] modify storm-kafka.md
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1992
@liu-zhaokun
Sorry the whole doc just seems outdated. It should be identical for `external/storm-kafka/README.md`.
#1721 was for that, but we just addressed it with only master branch.
I guess I could handle it manually. You can close this PR. Thanks for your contribution anyway!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1992: [STORM-2397] modify storm-kafka.md
Posted by liu-zhaokun <gi...@git.apache.org>.
Github user liu-zhaokun commented on the issue:
https://github.com/apache/storm/pull/1992
@HeartSaVioR
But the website [here ](http://storm.apache.org/releases/1.0.2/storm-kafka.html)has not been modified.My issues aim at modifying the website about storm 1.0.2.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1992: [STORM-2397] modify storm-kafka.md
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1992
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #1992: [STORM-2397] modify storm-kafka.md
Posted by liu-zhaokun <gi...@git.apache.org>.
Github user liu-zhaokun closed the pull request at:
https://github.com/apache/storm/pull/1992
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1992: [STORM-2397] modify storm-kafka.md
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1992
@liu-zhaokun Yes I fixed the codebase but not updated website yet since I'm in progress of merging others. I'll update the website today. Thanks for the reminder.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1992: [STORM-2397] modify storm-kafka.md
Posted by liu-zhaokun <gi...@git.apache.org>.
Github user liu-zhaokun commented on the issue:
https://github.com/apache/storm/pull/1992
Hi@HeartSaVioR ,what's the meaning of "+1",and what should I do next?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1992: [STORM-2397] modify storm-kafka.md
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1992
+1 is same as LGTM (Looks good to me). Since I (meaning one of committer) reviewed and approved the change, this is eligible to be merged to repo.
You don't need to make any change. I'll take merge step.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---