You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "LuciferYang (via GitHub)" <gi...@apache.org> on 2023/03/25 05:39:08 UTC

[GitHub] [spark] LuciferYang commented on a diff in pull request #40552: [SPARK-42921][SQL][TESTS] Split `timestampNTZ/datetime-special.sql` into w/ and w/o `ansi` suffix to pass sql analyzer test in ansi mode

LuciferYang commented on code in PR #40552:
URL: https://github.com/apache/spark/pull/40552#discussion_r1148309479


##########
sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/ThriftServerQueryTestSuite.scala:
##########
@@ -88,6 +88,8 @@ class ThriftServerQueryTestSuite extends SQLQueryTestSuite with SharedThriftServ
     "datetime-special.sql",
     "ansi/datetime-special.sql",
     "timestampNTZ/datetime-special.sql",
+    // SPARK-42921
+    "timestampNTZ/datetime-special-ansi.sql",

Review Comment:
   ignore in `ThriftServerQueryTestSuite`, same reason as `timestampNTZ/datetime-special.sql`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org