[GitHub] [airflow] dimberman commented on a diff in pull request #29642: Migrate tests in google/cloud/sensors from unittest to pytest

["dimberman (via GitHub)" <gi...@apache.org>]

dimberman commented on code in PR #29642:
URL: https://github.com/apache/airflow/pull/29642#discussion_r1112212612


##########
tests/providers/google/cloud/sensors/test_bigquery.py:
##########
@@ -37,7 +37,7 @@
 TEST_IMPERSONATION_CHAIN = ["ACCOUNT_1", "ACCOUNT_2", "ACCOUNT_3"]
 
 
-class TestBigqueryTableExistenceSensor(TestCase):
+class TestBigqueryTableExistenceSensor:

Review Comment:
   If we're switching from unittest to pytest then why are we even using test classes at all? We might as well go all the way and make the tests into functions. I'd rather make this change now while we're already modifying the code. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org