You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by jackylk <gi...@git.apache.org> on 2018/04/18 11:45:21 UTC
[GitHub] carbondata pull request #2184: [CARBONDATA-2357] Add column name and index m...
GitHub user jackylk opened a pull request:
https://github.com/apache/carbondata/pull/2184
[CARBONDATA-2357] Add column name and index mapping in Lucene datamap writer
- [ ] Any interfaces changed?
- [ ] Any backward compatibility impacted?
- [ ] Document update required?
- [ ] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jackylk/incubator-carbondata improvate-lucene-writer
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/2184.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2184
----
commit f41a09c20ca61b796cc4fbd70151460dd76cb113
Author: Jacky Li <ja...@...>
Date: 2018-04-18T11:41:36Z
improve performance
----
---
[GitHub] carbondata issue #2184: [CARBONDATA-2357] Add column name and index mapping ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2184
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4024/
---
[GitHub] carbondata issue #2184: [CARBONDATA-2357] Add column name and index mapping ...
Posted by QiangCai <gi...@git.apache.org>.
Github user QiangCai commented on the issue:
https://github.com/apache/carbondata/pull/2184
LGTM
---
[GitHub] carbondata pull request #2184: [CARBONDATA-2357] Add column name and index m...
Posted by QiangCai <gi...@git.apache.org>.
Github user QiangCai commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2184#discussion_r183196683
--- Diff: datamap/lucene/src/main/java/org/apache/carbondata/datamap/lucene/LuceneDataMapWriter.java ---
@@ -222,12 +236,10 @@ public void onPageAdded(int blockletId, int pageId, ColumnPage[] pages) throws I
//doc.add(new NumericDocValuesField(ROWID_NAME,rowId));
}
- // add other fields
- for (int colIdx = 0; colIdx < columnsCount; colIdx++) {
- if (indexedCarbonColumns.contains(pages[colIdx].getColumnSpec().getFieldName())) {
- if (!pages[colIdx].getNullBits().get(rowId)) {
- addField(doc, pages[colIdx], rowId, Field.Store.NO);
- }
+ // add indexed columns value into the document
+ for (int colIdx = 0; colIdx < luceneColumnIndex.length; colIdx++) {
+ if (!pages[luceneColumnIndex[colIdx]].getNullBits().get(rowId)) {
--- End diff --
The indexedCarbonColumns and pages have the same order. not required to check it again.
---
[GitHub] carbondata issue #2184: [CARBONDATA-2357] Add column name and index mapping ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2184
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5138/
---
[GitHub] carbondata issue #2184: [CARBONDATA-2357] Add column name and index mapping ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2184
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5218/
---
[GitHub] carbondata pull request #2184: [CARBONDATA-2357] Add column name and index m...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/carbondata/pull/2184
---
[GitHub] carbondata issue #2184: [CARBONDATA-2357] Add column name and index mapping ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2184
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4089/
---
[GitHub] carbondata issue #2184: [CARBONDATA-2357] Add column name and index mapping ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2184
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3932/
---
[GitHub] carbondata issue #2184: [CARBONDATA-2357] Add column name and index mapping ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2184
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5133/
---
[GitHub] carbondata issue #2184: [CARBONDATA-2357] Add column name and index mapping ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2184
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3917/
---
[GitHub] carbondata issue #2184: [CARBONDATA-2357] Add column name and index mapping ...
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on the issue:
https://github.com/apache/carbondata/pull/2184
retest this please
---
[GitHub] carbondata issue #2184: [CARBONDATA-2357] Add column name and index mapping ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2184
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5270/
---
[GitHub] carbondata issue #2184: [CARBONDATA-2357] Add column name and index mapping ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2184
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3912/
---
[GitHub] carbondata issue #2184: [CARBONDATA-2357] Add column name and index mapping ...
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on the issue:
https://github.com/apache/carbondata/pull/2184
retest this please
---
[GitHub] carbondata issue #2184: [CARBONDATA-2357] Add column name and index mapping ...
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on the issue:
https://github.com/apache/carbondata/pull/2184
retest this please
---