[GitHub] [hadoop] aajisaka commented on issue #1871: Hadoop-16899. Update HdfsDesign.md to reduce ambiguity.

[GitBox <gi...@apache.org>]

aajisaka commented on issue #1871: Hadoop-16899. Update HdfsDesign.md to reduce ambiguity.
URL: https://github.com/apache/hadoop/pull/1871#issuecomment-593742741
 
 
   Thank you for your contribution.
   
   The sentence seems still ambiguous to me
   
   > One third of replicas are on one node, two thirds of replicas are on one rack.
   
   -> Two replicas are on one rack, and the remaining replica is on one of the other racks.
   
   - The replication factor is 3 in this sentence, so 'one' seems clearer than 'one third'.
   - This sentence should tell that a replica is on a rack (instead of node) and the other two replicas are on one of 'the other' racks.
   
   The following sentence is not directly related to your PR, however, it can be fixed at the same time.
   
   > However, it does reduce the aggregate network bandwidth used when reading data since a block is placed in only two unique racks rather than three. With this policy, the replicas of a file do not evenly distribute across the racks. 
   
   * it does reduce -> it does not reduce
   
   If a block is placed in three unique racks, the probability of rack-local read will increase and the network bandwidth will be reduced when reading the data. Therefore I think 'does' should be changed to 'does not'.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org