You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Chandan Purushothama <Ch...@citrix.com> on 2014/11/27 01:19:01 UTC
Review Request 28492: CLOUDSTACK-7980 : Fixed the script
'/maint/test_egress_rules_host_maintenance.py' - Zone Network Type
Information should to be passed to VirtualMachine create method
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28492/
-----------------------------------------------------------
Review request for cloudstack and sangeetha hariharan.
Bugs: CLOUDSTACK-7980
https://issues.apache.org/jira/browse/CLOUDSTACK-7980
Repository: cloudstack-git
Description
-------
Currently, test cases in the test suite do not pass the Zone Network Type to the Virtual Machine class create method. This doesn't cause any problem with majority of the configurations except EIP-ELB Configuration. Hence Zone Network Type Information should be passed consciously to the create method to cover EIP-ELB Configuration.
Diffs
-----
test/integration/component/maint/test_egress_rules_host_maintenance.py a27ada3
Diff: https://reviews.apache.org/r/28492/diff/
Testing
-------
Executed One Test to prove the fix. This test belongs to a different test suite. But the fix is the same:
Test authorize ingress rule ... === TestName: test_authorizeIngressRule | Status : SUCCESS ===
ok
Ran 1 test in 126.613s
OK
Thanks,
Chandan Purushothama
Re: Review Request 28492: CLOUDSTACK-7980 : Fixed the script
'/maint/test_egress_rules_host_maintenance.py' - Zone Network Type
Information should to be passed to VirtualMachine create method
Posted by sangeetha hariharan <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28492/#review63166
-----------------------------------------------------------
Ship it!
Ship It!
- sangeetha hariharan
On Nov. 27, 2014, 12:19 a.m., Chandan Purushothama wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28492/
> -----------------------------------------------------------
>
> (Updated Nov. 27, 2014, 12:19 a.m.)
>
>
> Review request for cloudstack and sangeetha hariharan.
>
>
> Bugs: CLOUDSTACK-7980
> https://issues.apache.org/jira/browse/CLOUDSTACK-7980
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Currently, test cases in the test suite do not pass the Zone Network Type to the Virtual Machine class create method. This doesn't cause any problem with majority of the configurations except EIP-ELB Configuration. Hence Zone Network Type Information should be passed consciously to the create method to cover EIP-ELB Configuration.
>
>
> Diffs
> -----
>
> test/integration/component/maint/test_egress_rules_host_maintenance.py a27ada3
>
> Diff: https://reviews.apache.org/r/28492/diff/
>
>
> Testing
> -------
>
> Executed One Test to prove the fix. This test belongs to a different test suite. But the fix is the same:
>
> Test authorize ingress rule ... === TestName: test_authorizeIngressRule | Status : SUCCESS ===
> ok
>
> Ran 1 test in 126.613s
>
> OK
>
>
> Thanks,
>
> Chandan Purushothama
>
>