You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2020/10/02 17:01:44 UTC

[GitHub] [trafficcontrol] mitchell852 commented on a change in pull request #5092: Add warning when creating/updating jobs that overlap.

mitchell852 commented on a change in pull request #5092:
URL: https://github.com/apache/trafficcontrol/pull/5092#discussion_r498941434



##########
File path: traffic_portal/app/src/common/service/utils/ServerUtils.js
##########
@@ -67,6 +67,24 @@ var ServerUtils = function($window, propertiesModel, userModel) {
 		);
 	};
 
+	// Takes a response object from TO and converts all of its alerts to messages acceptable by the messageModel
+	this.convertResponseToMessages = function(response) {

Review comment:
       pretty sure you don't have to do this. messagemodel takes in an array or messages so all you have to do is
   
   ```
   					messageModel.setMessages(result.alerts, true);
   ```
   
   or 
   
   ```
   messageModel.setMessages(result.data.alerts, true);
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org