You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "alamb (via GitHub)" <gi...@apache.org> on 2025/01/21 14:55:17 UTC

[PR] Minor: make it clear Predicate is crate private [arrow-rs]

alamb opened a new pull request, #7001:
URL: https://github.com/apache/arrow-rs/pull/7001

   Draft until https://github.com/apache/arrow-rs/pull/6926 is merged
   
   # Which issue does this PR close?
   
   - Follow on to https://github.com/apache/arrow-rs/pull/6926
   
   # Rationale for this change
    
   `Predicate` is marked `pub` but it is in a non public mod
   
   https://github.com/apache/arrow-rs/blob/595a83561e6512c757bca2786f974abb3b711f1d/arrow-string/src/lib.rs#L24
   
   This gives it a false impression that it is part of the public API, which it is not: 
   * https://docs.rs/arrow/latest/arrow/index.html?search=Predicate
   * https://docs.rs/arrow-string/latest/arrow_string/?search=Predicate
   
   
   # What changes are included in this PR?
   
   Mark `pub(crate)` to make it explicit that this structure is not public
   
   # Are there any user-facing changes?
   
   
   <!--
   If there are user-facing changes then we may require documentation to be updated before approving the PR.
   -->
   
   <!---
   If there are any breaking changes to public APIs, please call them out.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Minor: make it clear Predicate is crate private [arrow-rs]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #7001:
URL: https://github.com/apache/arrow-rs/pull/7001#issuecomment-2607815485

   Thank you @tustvold 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Minor: make it clear Predicate is crate private [arrow-rs]

Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold merged PR #7001:
URL: https://github.com/apache/arrow-rs/pull/7001


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org