[GitHub] [incubator-kyuubi] wForget commented on a diff in pull request #2482: [KYUUBI #2419] Destroy the ProcBuilder process and call killApplication during closing session

[GitBox <gi...@apache.org>]

wForget commented on code in PR #2482:
URL: https://github.com/apache/incubator-kyuubi/pull/2482#discussion_r859296298


##########
kyuubi-server/src/main/scala/org/apache/kyuubi/operation/BatchJobSubmission.scala:
##########
@@ -149,7 +149,13 @@ class BatchJobSubmission(session: KyuubiBatchSessionImpl, batchRequest: BatchReq
   override def close(): Unit = {
     if (!isClosedOrCanceled) {
       if (builder != null) {
-        builder.close()
+        try {
+          builder.shutdown()
+          applicationManager.killApplication(builder.clusterManager(), batchId)

Review Comment:
   > For yarn-cluster mode and without application wait completion, it will kill the running spark app.
   
   Sorry, I mistakenly thought the close method was called when the job finished, so how about we add it in `KyuubiBatchSessionImpl#close`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org