You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/06/05 00:19:37 UTC
[GitHub] [incubator-superset] codecov-io commented on issue #7618: Add
Filter on DatabaseView that filters DBs Based on Role Access
codecov-io commented on issue #7618: Add Filter on DatabaseView that filters DBs Based on Role Access
URL: https://github.com/apache/incubator-superset/pull/7618#issuecomment-498890513
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/7618?src=pr&el=h1) Report
> Merging [#7618](https://codecov.io/gh/apache/incubator-superset/pull/7618?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/dbdb6b093aeb0b482494e7a4ee65b5836b5070ea?src=pr&el=desc) will **increase** coverage by `0.2%`.
> The diff coverage is `80%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/7618?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7618 +/- ##
=========================================
+ Coverage 65.37% 65.58% +0.2%
=========================================
Files 435 435
Lines 21513 21753 +240
Branches 2378 2393 +15
=========================================
+ Hits 14064 14266 +202
- Misses 7329 7366 +37
- Partials 120 121 +1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/7618?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/security.py](https://codecov.io/gh/apache/incubator-superset/pull/7618/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkucHk=) | `73.36% <100%> (-1.64%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/7618/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `72.87% <71.42%> (-0.01%)` | :arrow_down: |
| [superset/assets/src/SqlLab/reducers/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/7618/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9TcWxMYWIvcmVkdWNlcnMvc3FsTGFiLmpz) | `48.38% <0%> (-1.62%)` | :arrow_down: |
| [.../assets/src/SqlLab/components/AceEditorWrapper.jsx](https://codecov.io/gh/apache/incubator-superset/pull/7618/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9TcWxMYWIvY29tcG9uZW50cy9BY2VFZGl0b3JXcmFwcGVyLmpzeA==) | `57.31% <0%> (-1.02%)` | :arrow_down: |
| [.../assets/src/SqlLab/components/SqlEditorLeftBar.jsx](https://codecov.io/gh/apache/incubator-superset/pull/7618/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9TcWxMYWIvY29tcG9uZW50cy9TcWxFZGl0b3JMZWZ0QmFyLmpzeA==) | `39.62% <0%> (-0.81%)` | :arrow_down: |
| [...src/components/FilterableTable/FilterableTable.jsx](https://codecov.io/gh/apache/incubator-superset/pull/7618/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jb21wb25lbnRzL0ZpbHRlcmFibGVUYWJsZS9GaWx0ZXJhYmxlVGFibGUuanN4) | `90.21% <0%> (-0.8%)` | :arrow_down: |
| [superset/assets/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/7618/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9TcWxMYWIvYWN0aW9ucy9zcWxMYWIuanM=) | `63.4% <0%> (-0.79%)` | :arrow_down: |
| [...uperset/assets/src/SqlLab/components/ResultSet.jsx](https://codecov.io/gh/apache/incubator-superset/pull/7618/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9TcWxMYWIvY29tcG9uZW50cy9SZXN1bHRTZXQuanN4) | `79.54% <0%> (-0.46%)` | :arrow_down: |
| [superset/utils/core.py](https://codecov.io/gh/apache/incubator-superset/pull/7618/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.06% <0%> (-0.16%)` | :arrow_down: |
| ... and [14 more](https://codecov.io/gh/apache/incubator-superset/pull/7618/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/7618?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/7618?src=pr&el=footer). Last update [dbdb6b0...4d9c89b](https://codecov.io/gh/apache/incubator-superset/pull/7618?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org