You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@fluo.apache.org by GitBox <gi...@apache.org> on 2021/01/26 15:40:41 UTC
[GitHub] [fluo-muchos] GreenCee opened a new pull request #385: #384 Pin Ansible version in pip and update example properties for Azure
GreenCee opened a new pull request #385:
URL: https://github.com/apache/fluo-muchos/pull/385
Updates to keep Azure instructions working
Pinned pip instructions to match requirement.txt
Added Zookeeper 3.5.9 checksum
Updated properties example to use newer ZooKeeper and Accumulo 2.0.1
LMK if these should be broken up into different PRs
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fluo-muchos] arvindshmicrosoft commented on a change in pull request #385: #384 Pin Ansible version in pip and update example properties for Azure
Posted by GitBox <gi...@apache.org>.
arvindshmicrosoft commented on a change in pull request #385:
URL: https://github.com/apache/fluo-muchos/pull/385#discussion_r564803862
##########
File path: lib/tests/ec2/test_config.py
##########
@@ -32,8 +32,8 @@ def test_ec2_cluster():
"f68a6145029a9ea843b0305c90a7f5f0334d8a8ceeea94734267ec36421fe7fe"
)
assert c.checksum("accumulo") == (
- "sha256:"
- "df172111698c7a73aa031de09bd5589263a6b824482fbb9b4f0440a16602ed47"
+ "sha512:"
+ "b443839443a9f5098b55bc5c54be10c11fedbaea554ee6cd42eaa9311068c70bd611d7fc67698c91ec73da0e85b9907aa72b98d5eb4d49ea3a5d51b0c6c5785f"
Review comment:
```suggestion
"b443839443a9f5098b55bc5c54be10c11fedbaea554ee6cd42eaa9311068c70b"
"d611d7fc67698c91ec73da0e85b9907aa72b98d5eb4d49ea3a5d51b0c6c5785f"
```
##########
File path: lib/tests/azure/test_config.py
##########
@@ -38,8 +38,8 @@ def test_azure_cluster():
"f68a6145029a9ea843b0305c90a7f5f0334d8a8ceeea94734267ec36421fe7fe"
)
assert c.checksum("accumulo") == (
- "sha256:"
- "df172111698c7a73aa031de09bd5589263a6b824482fbb9b4f0440a16602ed47"
+ "sha512:"
+ "b443839443a9f5098b55bc5c54be10c11fedbaea554ee6cd42eaa9311068c70bd611d7fc67698c91ec73da0e85b9907aa72b98d5eb4d49ea3a5d51b0c6c5785f"
Review comment:
Just split the string into 2 strings. Python string concatenation will do the rest.
```suggestion
"b443839443a9f5098b55bc5c54be10c11fedbaea554ee6cd42eaa9311068c70b"
"d611d7fc67698c91ec73da0e85b9907aa72b98d5eb4d49ea3a5d51b0c6c5785f"
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fluo-muchos] GreenCee commented on pull request #385: #384 Pin Ansible version in pip and update example properties for Azure
Posted by GitBox <gi...@apache.org>.
GreenCee commented on pull request #385:
URL: https://github.com/apache/fluo-muchos/pull/385#issuecomment-767706875
Change to 2.0.1 is causing the checksum to fail. I'll update and resubmit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fluo-muchos] GreenCee edited a comment on pull request #385: #384 Pin Ansible version in pip and update example properties for Azure
Posted by GitBox <gi...@apache.org>.
GreenCee edited a comment on pull request #385:
URL: https://github.com/apache/fluo-muchos/pull/385#issuecomment-767706875
Change to point to Accumulo 2.0.1 is causing the checksum test to fail as it was expecting 2.0.0.
I'll update and resubmit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fluo-muchos] GreenCee commented on pull request #385: #384 Pin Ansible version in pip and update example properties for Azure
Posted by GitBox <gi...@apache.org>.
GreenCee commented on pull request #385:
URL: https://github.com/apache/fluo-muchos/pull/385#issuecomment-767816372
@arvindshmicrosoft Ok, done isolated the Ansible version changes. Let me know if there is something I should do to pretty up the git history
I'll apply the suggestion on the checksum formatting on a different PR. Lesson learned on atomic minimal changes :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fluo-muchos] arvindshmicrosoft commented on pull request #385: #384 Pin Ansible version in pip and update example properties for Azure
Posted by GitBox <gi...@apache.org>.
arvindshmicrosoft commented on pull request #385:
URL: https://github.com/apache/fluo-muchos/pull/385#issuecomment-767725429
Hi @GreenCee it may be safer to separate the PRs, just to keep the doc update independent of the changes to the versions and adding checksums...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fluo-muchos] keith-turner commented on pull request #385: #384 Pin Ansible version in pip and update example properties for Azure
Posted by GitBox <gi...@apache.org>.
keith-turner commented on pull request #385:
URL: https://github.com/apache/fluo-muchos/pull/385#issuecomment-880015188
@GreenCee we offer new contributors the chance to add their-self to the Fluo people page as a contributor. However we missed that you were a new first time contributor on this PR, please forgive the delay. If you would like to add yourself as a contributor, please [submit a PR](https://github.com/apache/fluo-website/edit/main/pages/people.md)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@fluo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fluo-muchos] ctubbsii merged pull request #385: #384 Pin Ansible version in pip and update example properties for Azure
Posted by GitBox <gi...@apache.org>.
ctubbsii merged pull request #385:
URL: https://github.com/apache/fluo-muchos/pull/385
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fluo-muchos] ctubbsii commented on pull request #385: #384 Pin Ansible version in pip and update example properties for Azure
Posted by GitBox <gi...@apache.org>.
ctubbsii commented on pull request #385:
URL: https://github.com/apache/fluo-muchos/pull/385#issuecomment-767816796
> @arvindshmicrosoft Ok, done isolated the Ansible version changes. Let me know if there is something I should do to pretty up the git history
I'll squash it on merge anyway, so no need to do any history cleanup. :)
> I'll apply the suggestion on the checksum formatting on a different PR. Lesson learned on atomic minimal changes :)
Thanks, @GreenCee !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fluo-muchos] ctubbsii commented on a change in pull request #385: #384 Pin Ansible version in pip and update example properties for Azure
Posted by GitBox <gi...@apache.org>.
ctubbsii commented on a change in pull request #385:
URL: https://github.com/apache/fluo-muchos/pull/385#discussion_r564816883
##########
File path: lib/tests/azure/test_config.py
##########
@@ -38,8 +38,8 @@ def test_azure_cluster():
"f68a6145029a9ea843b0305c90a7f5f0334d8a8ceeea94734267ec36421fe7fe"
)
assert c.checksum("accumulo") == (
- "sha256:"
- "df172111698c7a73aa031de09bd5589263a6b824482fbb9b4f0440a16602ed47"
+ "sha512:"
+ "b443839443a9f5098b55bc5c54be10c11fedbaea554ee6cd42eaa9311068c70bd611d7fc67698c91ec73da0e85b9907aa72b98d5eb4d49ea3a5d51b0c6c5785f"
Review comment:
Splitting into two strings makes it slightly harder to compare with the upstream published checksum, but if that's the only way to get around it, that's fine with me. I was hoping for the ability to add an exception to the check. Do you know if that is possible?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org