You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@poi.apache.org by ce...@apache.org on 2014/03/31 18:16:52 UTC
svn commit: r1583366 - in /poi/trunk/src/scratchpad/src/org/apache/poi/hwpf:
dev/RecordUtil.java model/Xst.java
Author: cedricwalter
Date: Mon Mar 31 16:16:52 2014
New Revision: 1583366
URL: http://svn.apache.org/r1583366
Log:
performance issue: removed instantiation of new String object by copying an existing string.
Modified:
poi/trunk/src/scratchpad/src/org/apache/poi/hwpf/dev/RecordUtil.java
poi/trunk/src/scratchpad/src/org/apache/poi/hwpf/model/Xst.java
Modified: poi/trunk/src/scratchpad/src/org/apache/poi/hwpf/dev/RecordUtil.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/scratchpad/src/org/apache/poi/hwpf/dev/RecordUtil.java?rev=1583366&r1=1583365&r2=1583366&view=diff
==============================================================================
--- poi/trunk/src/scratchpad/src/org/apache/poi/hwpf/dev/RecordUtil.java (original)
+++ poi/trunk/src/scratchpad/src/org/apache/poi/hwpf/dev/RecordUtil.java Mon Mar 31 16:16:52 2014
@@ -35,7 +35,7 @@ public class RecordUtil
{
String type = getBitFieldType( name, bitMask, parentType );
- String retVal = new String();
+ String retVal = "";
if ( withType.equals( "true" ) )
{
retVal = type + " ";
Modified: poi/trunk/src/scratchpad/src/org/apache/poi/hwpf/model/Xst.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/scratchpad/src/org/apache/poi/hwpf/model/Xst.java?rev=1583366&r1=1583365&r2=1583366&view=diff
==============================================================================
--- poi/trunk/src/scratchpad/src/org/apache/poi/hwpf/model/Xst.java (original)
+++ poi/trunk/src/scratchpad/src/org/apache/poi/hwpf/model/Xst.java Mon Mar 31 16:16:52 2014
@@ -144,6 +144,6 @@ public class Xst
@Override
public String toString()
{
- return new String( "Xst [" + _cch + "; " + _rgtchar + "]" );
+ return "Xst [" + _cch + "; " + _rgtchar + "]";
}
}
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@poi.apache.org
For additional commands, e-mail: commits-help@poi.apache.org