You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@pulsar.apache.org by Matteo Merli <ma...@gmail.com> on 2024/03/14 01:45:10 UTC

[VOTE] PIP-342: Support OpenTelemetry metrics in Pulsar client

PIP: https://github.com/apache/pulsar/pull/22178

WIP PR: https://github.com/apache/pulsar/pull/22179




--
Matteo Merli
<ma...@gmail.com>

Re: [VOTE] PIP-342: Support OpenTelemetry metrics in Pulsar client

Posted by 太上玄元道君 <da...@apache.org>.

+1 nonbinding

Matteo Merli <ma...@gmail.com> 于2024年3月14日周四 09:45写道：

> PIP: https://github.com/apache/pulsar/pull/22178
>
> WIP PR: https://github.com/apache/pulsar/pull/22179
>
>
>
>
> --
> Matteo Merli
> <ma...@gmail.com>
>

Re: [RESULT] [VOTE] PIP-342: Support OpenTelemetry metrics in Pulsar client

Posted by PengHui Li <pe...@apache.org>.

Sorry, I forgot to submit my PR review before. Just some minor comments
about the names. Please take a look.

Regards,
Penghui

On Fri, Mar 22, 2024 at 11:21 PM Matteo Merli <ma...@gmail.com>
wrote:

> Closing this vote with 4 binding and 4 non-binding +1s
>
> Binding +1s:
>  * Lari
>  * Mattison
>  * PengHui
>  * Matteo
>
> Non-Binding +1s:
>  * Dao Jun
>  * Apurva
>  * Asaf
>  * Zixuan
>
>
> Thanks,
> Matteo
>
>
> --
> Matteo Merli
> <ma...@gmail.com>
>
>
> On Thu, Mar 14, 2024 at 11:54 PM Zixuan Liu <no...@gmail.com> wrote:
>
> > +1 (non-binding)
> >
> > Thanks,
> > Zixuan
> >
> > PengHui Li <pe...@apache.org> 于2024年3月15日周五 09:47写道：
> >
> > > +1 (binding)
> > >
> > > Regards,
> > > Penghui
> > >
> > > On Fri, Mar 15, 2024 at 2:32 AM Asaf Mesika <as...@gmail.com>
> > wrote:
> > >
> > > > +1 (non-binding)
> > > >
> > > > On Thu, Mar 14, 2024 at 8:29 PM Apurva Telang <
> > apurvatelang15@gmail.com>
> > > > wrote:
> > > >
> > > > > +1 (non-binding)
> > > > >
> > > > > On Thu, Mar 14, 2024 at 2:12 AM mattison chao <
> > mattisonchao@gmail.com>
> > > > > wrote:
> > > > >
> > > > > > +1 (binding)
> > > > > >
> > > > > > Best,
> > > > > > Mattison
> > > > > > On Mar 14, 2024 at 15:55 +0800, Lari Hotari <lhotari@apache.org
> >,
> > > > wrote:
> > > > > > > +1 (binding)
> > > > > > >
> > > > > > > -Lari
> > > > > > >
> > > > > > > On Thu, 14 Mar 2024 at 03:45, Matteo Merli <
> > matteo.merli@gmail.com
> > > >
> > > > > > wrote:
> > > > > > > >
> > > > > > > > PIP: https://github.com/apache/pulsar/pull/22178
> > > > > > > >
> > > > > > > > WIP PR: https://github.com/apache/pulsar/pull/22179
> > > > > > > >
> > > > > > > >
> > > > > > > >
> > > > > > > >
> > > > > > > > --
> > > > > > > > Matteo Merli
> > > > > > > > <ma...@gmail.com>
> > > > > >
> > > > >
> > > > >
> > > > > --
> > > > > Best regards,
> > > > > Apurva Telang.
> > > > >
> > > >
> > >
> >
>

[RESULT] [VOTE] PIP-342: Support OpenTelemetry metrics in Pulsar client

Posted by Matteo Merli <ma...@gmail.com>.

Closing this vote with 4 binding and 4 non-binding +1s

Binding +1s:
 * Lari
 * Mattison
 * PengHui
 * Matteo

Non-Binding +1s:
 * Dao Jun
 * Apurva
 * Asaf
 * Zixuan


Thanks,
Matteo


--
Matteo Merli
<ma...@gmail.com>


On Thu, Mar 14, 2024 at 11:54 PM Zixuan Liu <no...@gmail.com> wrote:

> +1 (non-binding)
>
> Thanks,
> Zixuan
>
> PengHui Li <pe...@apache.org> 于2024年3月15日周五 09:47写道：
>
> > +1 (binding)
> >
> > Regards,
> > Penghui
> >
> > On Fri, Mar 15, 2024 at 2:32 AM Asaf Mesika <as...@gmail.com>
> wrote:
> >
> > > +1 (non-binding)
> > >
> > > On Thu, Mar 14, 2024 at 8:29 PM Apurva Telang <
> apurvatelang15@gmail.com>
> > > wrote:
> > >
> > > > +1 (non-binding)
> > > >
> > > > On Thu, Mar 14, 2024 at 2:12 AM mattison chao <
> mattisonchao@gmail.com>
> > > > wrote:
> > > >
> > > > > +1 (binding)
> > > > >
> > > > > Best,
> > > > > Mattison
> > > > > On Mar 14, 2024 at 15:55 +0800, Lari Hotari <lh...@apache.org>,
> > > wrote:
> > > > > > +1 (binding)
> > > > > >
> > > > > > -Lari
> > > > > >
> > > > > > On Thu, 14 Mar 2024 at 03:45, Matteo Merli <
> matteo.merli@gmail.com
> > >
> > > > > wrote:
> > > > > > >
> > > > > > > PIP: https://github.com/apache/pulsar/pull/22178
> > > > > > >
> > > > > > > WIP PR: https://github.com/apache/pulsar/pull/22179
> > > > > > >
> > > > > > >
> > > > > > >
> > > > > > >
> > > > > > > --
> > > > > > > Matteo Merli
> > > > > > > <ma...@gmail.com>
> > > > >
> > > >
> > > >
> > > > --
> > > > Best regards,
> > > > Apurva Telang.
> > > >
> > >
> >
>

Re: [VOTE] PIP-342: Support OpenTelemetry metrics in Pulsar client

Posted by Zixuan Liu <no...@gmail.com>.

+1 (non-binding)

Thanks,
Zixuan

PengHui Li <pe...@apache.org> 于2024年3月15日周五 09:47写道：

> +1 (binding)
>
> Regards,
> Penghui
>
> On Fri, Mar 15, 2024 at 2:32 AM Asaf Mesika <as...@gmail.com> wrote:
>
> > +1 (non-binding)
> >
> > On Thu, Mar 14, 2024 at 8:29 PM Apurva Telang <ap...@gmail.com>
> > wrote:
> >
> > > +1 (non-binding)
> > >
> > > On Thu, Mar 14, 2024 at 2:12 AM mattison chao <ma...@gmail.com>
> > > wrote:
> > >
> > > > +1 (binding)
> > > >
> > > > Best,
> > > > Mattison
> > > > On Mar 14, 2024 at 15:55 +0800, Lari Hotari <lh...@apache.org>,
> > wrote:
> > > > > +1 (binding)
> > > > >
> > > > > -Lari
> > > > >
> > > > > On Thu, 14 Mar 2024 at 03:45, Matteo Merli <matteo.merli@gmail.com
> >
> > > > wrote:
> > > > > >
> > > > > > PIP: https://github.com/apache/pulsar/pull/22178
> > > > > >
> > > > > > WIP PR: https://github.com/apache/pulsar/pull/22179
> > > > > >
> > > > > >
> > > > > >
> > > > > >
> > > > > > --
> > > > > > Matteo Merli
> > > > > > <ma...@gmail.com>
> > > >
> > >
> > >
> > > --
> > > Best regards,
> > > Apurva Telang.
> > >
> >
>

Re: [VOTE] PIP-342: Support OpenTelemetry metrics in Pulsar client

Posted by PengHui Li <pe...@apache.org>.

+1 (binding)

Regards,
Penghui

On Fri, Mar 15, 2024 at 2:32 AM Asaf Mesika <as...@gmail.com> wrote:

> +1 (non-binding)
>
> On Thu, Mar 14, 2024 at 8:29 PM Apurva Telang <ap...@gmail.com>
> wrote:
>
> > +1 (non-binding)
> >
> > On Thu, Mar 14, 2024 at 2:12 AM mattison chao <ma...@gmail.com>
> > wrote:
> >
> > > +1 (binding)
> > >
> > > Best,
> > > Mattison
> > > On Mar 14, 2024 at 15:55 +0800, Lari Hotari <lh...@apache.org>,
> wrote:
> > > > +1 (binding)
> > > >
> > > > -Lari
> > > >
> > > > On Thu, 14 Mar 2024 at 03:45, Matteo Merli <ma...@gmail.com>
> > > wrote:
> > > > >
> > > > > PIP: https://github.com/apache/pulsar/pull/22178
> > > > >
> > > > > WIP PR: https://github.com/apache/pulsar/pull/22179
> > > > >
> > > > >
> > > > >
> > > > >
> > > > > --
> > > > > Matteo Merli
> > > > > <ma...@gmail.com>
> > >
> >
> >
> > --
> > Best regards,
> > Apurva Telang.
> >
>

Re: [VOTE] PIP-342: Support OpenTelemetry metrics in Pulsar client

Posted by Asaf Mesika <as...@gmail.com>.

+1 (non-binding)

On Thu, Mar 14, 2024 at 8:29 PM Apurva Telang <ap...@gmail.com>
wrote:

> +1 (non-binding)
>
> On Thu, Mar 14, 2024 at 2:12 AM mattison chao <ma...@gmail.com>
> wrote:
>
> > +1 (binding)
> >
> > Best,
> > Mattison
> > On Mar 14, 2024 at 15:55 +0800, Lari Hotari <lh...@apache.org>, wrote:
> > > +1 (binding)
> > >
> > > -Lari
> > >
> > > On Thu, 14 Mar 2024 at 03:45, Matteo Merli <ma...@gmail.com>
> > wrote:
> > > >
> > > > PIP: https://github.com/apache/pulsar/pull/22178
> > > >
> > > > WIP PR: https://github.com/apache/pulsar/pull/22179
> > > >
> > > >
> > > >
> > > >
> > > > --
> > > > Matteo Merli
> > > > <ma...@gmail.com>
> >
>
>
> --
> Best regards,
> Apurva Telang.
>

Re: [VOTE] PIP-342: Support OpenTelemetry metrics in Pulsar client

Posted by Apurva Telang <ap...@gmail.com>.

+1 (non-binding)

On Thu, Mar 14, 2024 at 2:12 AM mattison chao <ma...@gmail.com>
wrote:

> +1 (binding)
>
> Best,
> Mattison
> On Mar 14, 2024 at 15:55 +0800, Lari Hotari <lh...@apache.org>, wrote:
> > +1 (binding)
> >
> > -Lari
> >
> > On Thu, 14 Mar 2024 at 03:45, Matteo Merli <ma...@gmail.com>
> wrote:
> > >
> > > PIP: https://github.com/apache/pulsar/pull/22178
> > >
> > > WIP PR: https://github.com/apache/pulsar/pull/22179
> > >
> > >
> > >
> > >
> > > --
> > > Matteo Merli
> > > <ma...@gmail.com>
>


-- 
Best regards,
Apurva Telang.

Re: [VOTE] PIP-342: Support OpenTelemetry metrics in Pulsar client

Posted by mattison chao <ma...@gmail.com>.

+1 (binding)

Best,
Mattison
On Mar 14, 2024 at 15:55 +0800, Lari Hotari <lh...@apache.org>, wrote:
> +1 (binding)
>
> -Lari
>
> On Thu, 14 Mar 2024 at 03:45, Matteo Merli <ma...@gmail.com> wrote:
> >
> > PIP: https://github.com/apache/pulsar/pull/22178
> >
> > WIP PR: https://github.com/apache/pulsar/pull/22179
> >
> >
> >
> >
> > --
> > Matteo Merli
> > <ma...@gmail.com>

Re: [VOTE] PIP-342: Support OpenTelemetry metrics in Pulsar client

Posted by Lari Hotari <lh...@apache.org>.

+1 (binding)

-Lari

On Thu, 14 Mar 2024 at 03:45, Matteo Merli <ma...@gmail.com> wrote:
>
> PIP: https://github.com/apache/pulsar/pull/22178
>
> WIP PR: https://github.com/apache/pulsar/pull/22179
>
>
>
>
> --
> Matteo Merli
> <ma...@gmail.com>