Re: [PR] fix(dashboard): resolve to a fixed point when un-clipping scrollable chart content [superset]

["aminghadersohi (via GitHub)" <gi...@apache.org>]

aminghadersohi commented on code in PR #44102:
URL: https://github.com/apache/superset/pull/44102#discussion_r4266332782


##########
tests/unit_tests/utils/test_screenshot_utils.py:
##########
@@ -1867,3 +1867,109 @@ def test_expand_scrollable_content_js_unrolls_ag_grid_and_css_scroll() -> None:
     # bounded by a report's remaining deadline (see webdriver_test.py).
     assert "async (maxWaitMs) =>" in EXPAND_SCROLLABLE_CONTENT_JS
     assert "Date.now() + maxWaitMs" in EXPAND_SCROLLABLE_CONTENT_JS
+
+    # The generic-descendant reset repeats to a fixed point (bounded), not a
+    # single pass: an ancestor whose own height was computed as the sum of
+    # its still-clipped children (e.g. plugin-chart-table's `role="table"`
+    # sticky wrapper in useSticky.tsx) has scrollHeight == clientHeight
+    # *before* its child is expanded, so a single querySelectorAll pass
+    # skips it -- see test_expand_scrollable_content_resolves_nested_ancestor_clip
+    # below for the real-browser reproduction.
+    assert "changedInPass" in EXPAND_SCROLLABLE_CONTENT_JS
+    assert "passes < 5" in EXPAND_SCROLLABLE_CONTENT_JS

Review Comment:
   As the sole guard, these two survive all 6 loop mutations I ran - including `let changedInPass = false` (loop never runs) and a `passes < 1` cap (single pass, i.e. the pre-fix bug). The Playwright test kills 3 of those but is skipped in CI, so nothing CI-enforced observes the fixed point.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org