You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/06/18 21:16:37 UTC

[GitHub] [airflow] malthe edited a comment on pull request #16314: Add support for non-RSA type client host key

malthe edited a comment on pull request #16314:
URL: https://github.com/apache/airflow/pull/16314#issuecomment-864016126


   @potiuk in this case I think there is no particular need for a refactoring; the code is alright as it is – if I was going to suggest changing anything, it would be the ability to provide username, password etc. as arguments to the hook function – rather than relying on the connection alone (that is, I would remove it).
   
   I have seen some hooks use a connection object instead of a connection id and this makes sense I think. It allows you to write out the connection details or look up using `get_connection`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org