You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Johan Corveleyn <jc...@apache.org> on 2020/12/18 00:00:34 UTC
Re: svn commit: r1884579 - /subversion/branches/1.14.x/STATUS
On Fri, Dec 18, 2020 at 12:50 AM <jc...@apache.org> wrote:
>
> Author: jcorvel
> Date: Thu Dec 17 23:50:27 2020
> New Revision: 1884579
>
> URL: http://svn.apache.org/viewvc?rev=1884579&view=rev
> Log:
> * 1.14.x/STATUS: Add -1 vote to r1880192 (issue #4862), because the test
> fails on Windows. Vote for the test fix (r1881985 group). If the test
> fix gets enough votes too, my vote for r1880192 can be converted to +1.
>
> Modified:
> subversion/branches/1.14.x/STATUS
>
> Modified: subversion/branches/1.14.x/STATUS
> URL: http://svn.apache.org/viewvc/subversion/branches/1.14.x/STATUS?rev=1884579&r1=1884578&r2=1884579&view=diff
> ==============================================================================
> --- subversion/branches/1.14.x/STATUS (original)
> +++ subversion/branches/1.14.x/STATUS Thu Dec 17 23:50:27 2020
> @@ -23,15 +23,17 @@ Candidate changes:
> r1878997, r1879192, r1879474, r1879959 (Fix issue #4859)
> Votes:
> +1: julianfoad, hartmannathan
> + -1: jcorvel (test FAIL on Windows;
> + +1 if r1881985 group (see below) is backported too)
>
> * r1881985, r1882105
> Follow up to r1880192: Fix an EOL issue in test on Windows.
> Justification:
> We should test correctly on Windows environment, too.
> Depends:
> - rr1880192
> + r1880192
> Votes:
> - +1: futatuki
> + +1: futatuki, jcorvel
>
> * r1875675
> Rewrite load_normalize_node_props to avoid literal trailing spaces.
>
Just as a heads up: I was ready to vote for an approve r1880192 (issue
#4862 -- Merge: the resulting mergeinfo is non-deterministic) for
1.14.x, but as Yasuhito also discovered: there is an EOL issue in the
test, which makes it fail on Windows. So it really needs to be
accompanied by the r1881985 group.
If anyone can add a third vote to the r1881985 group, they get the
other approval as a bonus :-).
(cc'ing Julian and Nathan personally, because they have voted already
for the first issue, so already know the context)
--
Johan
Re: svn commit: r1884579 - /subversion/branches/1.14.x/STATUS
Posted by Johan Corveleyn <jc...@apache.org>.
On Fri, Dec 18, 2020 at 1:00 AM Johan Corveleyn <jc...@apache.org> wrote:
>
> On Fri, Dec 18, 2020 at 12:50 AM <jc...@apache.org> wrote:
> >
> > Author: jcorvel
> > Date: Thu Dec 17 23:50:27 2020
> > New Revision: 1884579
> >
> > URL: http://svn.apache.org/viewvc?rev=1884579&view=rev
> > Log:
> > * 1.14.x/STATUS: Add -1 vote to r1880192 (issue #4862), because the test
> > fails on Windows. Vote for the test fix (r1881985 group). If the test
> > fix gets enough votes too, my vote for r1880192 can be converted to +1.
> >
> > Modified:
> > subversion/branches/1.14.x/STATUS
> >
> > Modified: subversion/branches/1.14.x/STATUS
> > URL: http://svn.apache.org/viewvc/subversion/branches/1.14.x/STATUS?rev=1884579&r1=1884578&r2=1884579&view=diff
> > ==============================================================================
> > --- subversion/branches/1.14.x/STATUS (original)
> > +++ subversion/branches/1.14.x/STATUS Thu Dec 17 23:50:27 2020
> > @@ -23,15 +23,17 @@ Candidate changes:
> > r1878997, r1879192, r1879474, r1879959 (Fix issue #4859)
> > Votes:
> > +1: julianfoad, hartmannathan
> > + -1: jcorvel (test FAIL on Windows;
> > + +1 if r1881985 group (see below) is backported too)
> >
> > * r1881985, r1882105
> > Follow up to r1880192: Fix an EOL issue in test on Windows.
> > Justification:
> > We should test correctly on Windows environment, too.
> > Depends:
> > - rr1880192
> > + r1880192
> > Votes:
> > - +1: futatuki
> > + +1: futatuki, jcorvel
> >
> > * r1875675
> > Rewrite load_normalize_node_props to avoid literal trailing spaces.
> >
>
> Just as a heads up: I was ready to vote for an approve r1880192 (issue
> #4862 -- Merge: the resulting mergeinfo is non-deterministic) for
> 1.14.x, but as Yasuhito also discovered: there is an EOL issue in the
> test, which makes it fail on Windows. So it really needs to be
> accompanied by the r1881985 group.
>
> If anyone can add a third vote to the r1881985 group, they get the
> other approval as a bonus :-).
>
> (cc'ing Julian and Nathan personally, because they have voted already
> for the first issue, so already know the context)
A small addition: same issue for the 1.10.x backports of the same
revisions. I just added the nomination of the test-EOL-fix (r1881985)
to 1.10.x/STATUS, where it was not listed yet. If anyone goes through
1.14.x/STATUS for this, you might as well take a look at 1.10.x/STATUS
:-).
--
Johan
Re: svn commit: r1884579 - /subversion/branches/1.14.x/STATUS
Posted by Johan Corveleyn <jc...@apache.org>.
On Fri, Dec 18, 2020 at 8:28 AM Julian Foad <ju...@apache.org> wrote:
>
> Nathan Hartman wrote:
> > Thanks for the heads up and all your work to push this train forward.
>
> Seconded.
Thanks, and no problem. I'm only adding a little extra push, no more
than the other voters already did, and certainly less than the
committers of the original fixes did :-).
I'm only sorry it took me so long to get around to it.
Let's hope we can keep the train keep rolling, and get some new
releases out soon ...
--
Johan
Re: svn commit: r1884579 - /subversion/branches/1.14.x/STATUS
Posted by Julian Foad <ju...@apache.org>.
Nathan Hartman wrote:
> Thanks for the heads up and all your work to push this train forward.
Seconded.
> Approved
Thank you.
- Julian
Re: svn commit: r1884579 - /subversion/branches/1.14.x/STATUS
Posted by Daniel Shahaf <d....@daniel.shahaf.name>.
Nathan Hartman wrote on Wed, Jan 27, 2021 at 13:38:02 -0500:
> On Fri, Dec 18, 2020 at 1:51 AM Nathan Hartman <ha...@gmail.com> wrote:
> >
> > On Thu, Dec 17, 2020 at 7:00 PM Johan Corveleyn <jc...@apache.org> wrote:
> > > Just as a heads up: I was ready to vote for an approve r1880192 (issue
> > > #4862 -- Merge: the resulting mergeinfo is non-deterministic) for
> > > 1.14.x, but as Yasuhito also discovered: there is an EOL issue in the
> > > test, which makes it fail on Windows. So it really needs to be
> > > accompanied by the r1881985 group.
> > >
> > > If anyone can add a third vote to the r1881985 group, they get the
> > > other approval as a bonus :-).
> > >
> > > (cc'ing Julian and Nathan personally, because they have voted already
> > > for the first issue, so already know the context)
> >
> > Thanks for the heads up and all your work to push this train forward.
> >
> > Yes, the r1881985 group fixes a test that was added in r1880192.
> > (Probably it should have been grouped with r1880192 in STATUS, but
> > since they have different combinations of votes, I'm leaving them
> > separate.)
> >
> > I added my vote to the r1881985 group, approving. Accordingly I
> > converted your vote on r1880192 to +1 and moved both groups to
> > Approved together.
> >
> > Done in separate commits r1884596, r1884597, r1884598.
> >
> > The above is for 1.14.x; I haven't done 1.10.x yet...
>
> Just a heads up, I have finally done the same for 1.10.x, likewise in
> 3 separate commits:
>
> * r1885947 (my vote for the r1881985 group)
> * r1885948 (upgrade Johan's vote for r1880192 per earlier conversations)
> * r1885949 (move both groups to Approved)
Thanks!
Re: svn commit: r1884579 - /subversion/branches/1.14.x/STATUS
Posted by Nathan Hartman <ha...@gmail.com>.
On Fri, Dec 18, 2020 at 1:51 AM Nathan Hartman <ha...@gmail.com> wrote:
>
> On Thu, Dec 17, 2020 at 7:00 PM Johan Corveleyn <jc...@apache.org> wrote:
> > Just as a heads up: I was ready to vote for an approve r1880192 (issue
> > #4862 -- Merge: the resulting mergeinfo is non-deterministic) for
> > 1.14.x, but as Yasuhito also discovered: there is an EOL issue in the
> > test, which makes it fail on Windows. So it really needs to be
> > accompanied by the r1881985 group.
> >
> > If anyone can add a third vote to the r1881985 group, they get the
> > other approval as a bonus :-).
> >
> > (cc'ing Julian and Nathan personally, because they have voted already
> > for the first issue, so already know the context)
>
> Thanks for the heads up and all your work to push this train forward.
>
> Yes, the r1881985 group fixes a test that was added in r1880192.
> (Probably it should have been grouped with r1880192 in STATUS, but
> since they have different combinations of votes, I'm leaving them
> separate.)
>
> I added my vote to the r1881985 group, approving. Accordingly I
> converted your vote on r1880192 to +1 and moved both groups to
> Approved together.
>
> Done in separate commits r1884596, r1884597, r1884598.
>
> The above is for 1.14.x; I haven't done 1.10.x yet...
Just a heads up, I have finally done the same for 1.10.x, likewise in
3 separate commits:
* r1885947 (my vote for the r1881985 group)
* r1885948 (upgrade Johan's vote for r1880192 per earlier conversations)
* r1885949 (move both groups to Approved)
Cheers,
Nathan
Re: svn commit: r1884579 - /subversion/branches/1.14.x/STATUS
Posted by Nathan Hartman <ha...@gmail.com>.
On Thu, Dec 17, 2020 at 7:00 PM Johan Corveleyn <jc...@apache.org> wrote:
> Just as a heads up: I was ready to vote for an approve r1880192 (issue
> #4862 -- Merge: the resulting mergeinfo is non-deterministic) for
> 1.14.x, but as Yasuhito also discovered: there is an EOL issue in the
> test, which makes it fail on Windows. So it really needs to be
> accompanied by the r1881985 group.
>
> If anyone can add a third vote to the r1881985 group, they get the
> other approval as a bonus :-).
>
> (cc'ing Julian and Nathan personally, because they have voted already
> for the first issue, so already know the context)
Thanks for the heads up and all your work to push this train forward.
Yes, the r1881985 group fixes a test that was added in r1880192.
(Probably it should have been grouped with r1880192 in STATUS, but
since they have different combinations of votes, I'm leaving them
separate.)
I added my vote to the r1881985 group, approving. Accordingly I
converted your vote on r1880192 to +1 and moved both groups to
Approved together.
Done in separate commits r1884596, r1884597, r1884598.
The above is for 1.14.x; I haven't done 1.10.x yet...
Cheers,
Nathan