You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2013/02/08 00:12:33 UTC

Re: Review Request: Fix for doing executor setup inside the forked process in cgroups isolation module

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8096/
-----------------------------------------------------------

(Updated Feb. 7, 2013, 11:12 p.m.)


Review request for mesos, Benjamin Hindman and Ben Mahler.


Changes
-------

Added bug MESOS-262.


Description
-------

Now, we do the executor setup (fetching etc) inside the forked process but before assigning the process to its own cgroup.

This accomplishes two things:
--> unblocks the cgroups isolation module from any potential hangs during executor setup
--> does not charge (for memory) the executor for the setup


This addresses bugs MESOS-262 and MESOS-310.
    https://issues.apache.org/jira/browse/MESOS-262
    https://issues.apache.org/jira/browse/MESOS-310


Diffs
-----

  src/slave/cgroups_isolation_module.cpp 8211618d7729350654e2d17946c5b912ed9dda6a 
  src/slave/process_based_isolation_module.cpp 16fd584e78db2c517d828f2576ab8a38c5ce57ad 

Diff: https://reviews.apache.org/r/8096/diff/


Testing
-------

sudo make check


Thanks,

Vinod Kone

Re: Review Request: Fix for doing executor setup inside the forked process in cgroups isolation module

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8096/
-----------------------------------------------------------

(Updated Feb. 9, 2013, 12:05 a.m.)


Review request for mesos, Benjamin Hindman and Ben Mahler.


Changes
-------

No need to re-review. Just uploading a rebased diff for posterity.

Submitting now.


Description
-------

Now, we do the executor setup (fetching etc) inside the forked process but before assigning the process to its own cgroup.

This accomplishes two things:
--> unblocks the cgroups isolation module from any potential hangs during executor setup
--> does not charge (for memory) the executor for the setup


This addresses bugs MESOS-262 and MESOS-310.
    https://issues.apache.org/jira/browse/MESOS-262
    https://issues.apache.org/jira/browse/MESOS-310


Diffs (updated)
-----

  src/slave/cgroups_isolation_module.cpp 63cefc3 
  src/slave/process_based_isolation_module.cpp 3d50a4b 

Diff: https://reviews.apache.org/r/8096/diff/


Testing
-------

sudo make check


Thanks,

Vinod Kone