[jira] [Commented] (OOZIE-2644) Skip queuing Notification Commands when there's nothing to notify

["Attila Sasvari (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OOZIE-2644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16218463#comment-16218463 ] 

Attila Sasvari commented on OOZIE-2644:
---------------------------------------

Adding a lot of {{CoordActionNotificationXCommand}} or {{WorkflowNotificationXCommand}} to the callable queue might also result in delay in marking an action completed in the Oozie database. For example: after the CallbackServlet receives a GET request with action status=SUCCEEDED (i.e. Oozie launcher job has ended and notified the Oozie server), it might take a while to persist this information if there are a lot of XCommand-s doing basically nothing. In the worst case, some might even fail to meet their SLA-s because of this (e.g. next action is not started on time).

> Skip queuing Notification Commands when there's nothing to notify
> -----------------------------------------------------------------
>
>                 Key: OOZIE-2644
>                 URL: https://issues.apache.org/jira/browse/OOZIE-2644
>             Project: Oozie
>          Issue Type: Improvement
>    Affects Versions: 3.1.3
>            Reporter: Robert Kanter
>            Assignee: Azrael Seoeun
>             Fix For: 5.0.0
>
>         Attachments: OOZIE-2644.1.patch, OOZIE-2644.2.patch
>
>
> When you use the [Workflow|https://oozie.apache.org/docs/4.2.0/WorkflowFunctionalSpec.html#a5_Workflow_Notifications] or [Coordinator|https://oozie.apache.org/docs/4.2.0/CoordinatorFunctionalSpec.html#a15._Coordinator_Notifications] Notification features, Oozie can end up queuing up a lot of {{WorkflowNotificationXCommand}} and {{CoordActionNotificationXCommand}}.  This happens even if there's no notification configured on the job (which I imagine is most of the time); in this case, the {{execute}} method simply does nothing.  This is wasteful and clogs the queue up.  
> We should change the code so that it doesn't queue up one of these Commands unless there's actually a URL to notify.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)