You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tuscany.apache.org by "Amita Vadhavkar (JIRA)" <tu...@ws.apache.org> on 2007/05/28 13:55:18 UTC
[jira] Created: (TUSCANY-1304) DAS does not allow multiple updates
on same table in one applyChanges()
DAS does not allow multiple updates on same table in one applyChanges()
-----------------------------------------------------------------------
Key: TUSCANY-1304
URL: https://issues.apache.org/jira/browse/TUSCANY-1304
Project: Tuscany
Issue Type: Bug
Components: Java DAS RDB
Affects Versions: Java-DAS-M3
Reporter: Amita Vadhavkar
ChangeFactory.getUpdateCommand() in JAVA DAS, has logic like this -
if (updateCommand == null) {
...do something to create a new update command
}
else{
...just return the existing update command.
}
With this, in the current case, UpdateGenerator.INSTANCE.getUpdateCommand() gets called only once
instead of n times and all the returns from ChangeFactory.getUpdateCommand() just return the
same updateCommand which is supposed to be only valid for first update command in current batch.
So when it comes to ChangeOperation.execute() - as ChangeSummarizer.loadChanges() has done a correct
while loop passing new changedObject, the SET clause in UPDATE command gets correct param values,
BUT the WHERE clause gets just the parameter from the first UPDATE and thus fails.
I have tried commenting the above if and checked that the updates happen correctly.
This JIRA is to further discuss this issue and get to resolution
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org
[jira] Assigned: (TUSCANY-1304) DAS does not allow multiple updates
on same table in one applyChanges()
Posted by "Luciano Resende (JIRA)" <tu...@ws.apache.org>.
[ https://issues.apache.org/jira/browse/TUSCANY-1304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Luciano Resende reassigned TUSCANY-1304:
----------------------------------------
Assignee: Luciano Resende
> DAS does not allow multiple updates on same table in one applyChanges()
> -----------------------------------------------------------------------
>
> Key: TUSCANY-1304
> URL: https://issues.apache.org/jira/browse/TUSCANY-1304
> Project: Tuscany
> Issue Type: Bug
> Components: Java DAS RDB
> Affects Versions: Java-DAS-beta1
> Reporter: Amita Vadhavkar
> Assignee: Luciano Resende
> Fix For: Java-DAS-beta1
>
>
> ChangeFactory.getUpdateCommand() in JAVA DAS, has logic like this -
> if (updateCommand == null) {
> ...do something to create a new update command
> }
> else{
> ...just return the existing update command.
> }
> With this, in the current case, UpdateGenerator.INSTANCE.getUpdateCommand() gets called only once
> instead of n times and all the returns from ChangeFactory.getUpdateCommand() just return the
> same updateCommand which is supposed to be only valid for first update command in current batch.
> So when it comes to ChangeOperation.execute() - as ChangeSummarizer.loadChanges() has done a correct
> while loop passing new changedObject, the SET clause in UPDATE command gets correct param values,
> BUT the WHERE clause gets just the parameter from the first UPDATE and thus fails.
> I have tried commenting the above if and checked that the updates happen correctly.
> This JIRA is to further discuss this issue and get to resolution
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org
[jira] Resolved: (TUSCANY-1304) DAS does not allow multiple updates
on same table in one applyChanges()
Posted by "Luciano Resende (JIRA)" <tu...@ws.apache.org>.
[ https://issues.apache.org/jira/browse/TUSCANY-1304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Luciano Resende resolved TUSCANY-1304.
--------------------------------------
Resolution: Fixed
Fixed under revision #543710
> DAS does not allow multiple updates on same table in one applyChanges()
> -----------------------------------------------------------------------
>
> Key: TUSCANY-1304
> URL: https://issues.apache.org/jira/browse/TUSCANY-1304
> Project: Tuscany
> Issue Type: Bug
> Components: Java DAS RDB
> Affects Versions: Java-DAS-beta1
> Reporter: Amita Vadhavkar
> Assignee: Luciano Resende
> Fix For: Java-DAS-beta1
>
>
> ChangeFactory.getUpdateCommand() in JAVA DAS, has logic like this -
> if (updateCommand == null) {
> ...do something to create a new update command
> }
> else{
> ...just return the existing update command.
> }
> With this, in the current case, UpdateGenerator.INSTANCE.getUpdateCommand() gets called only once
> instead of n times and all the returns from ChangeFactory.getUpdateCommand() just return the
> same updateCommand which is supposed to be only valid for first update command in current batch.
> So when it comes to ChangeOperation.execute() - as ChangeSummarizer.loadChanges() has done a correct
> while loop passing new changedObject, the SET clause in UPDATE command gets correct param values,
> BUT the WHERE clause gets just the parameter from the first UPDATE and thus fails.
> I have tried commenting the above if and checked that the updates happen correctly.
> This JIRA is to further discuss this issue and get to resolution
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org