You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/08/24 15:28:04 UTC
[GitHub] [airflow] turbaszek opened a new pull request #10514: Truly clear tis before runing dag test
turbaszek opened a new pull request #10514:
URL: https://github.com/apache/airflow/pull/10514
This PR adds logic to `airflow dags test` that removes task instances. This helps with debugging process where number of tasks and their names may change during development.
Closes #10503
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj edited a comment on pull request #10514: Truly clear tis before runing dag test
Posted by GitBox <gi...@apache.org>.
mik-laj edited a comment on pull request #10514:
URL: https://github.com/apache/airflow/pull/10514#issuecomment-679199464
@michalslowikowski00 Can you look at it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #10514: Truly clear tis before runing dag test
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #10514:
URL: https://github.com/apache/airflow/pull/10514#issuecomment-679199464
@mmichalslowikowski00 Can you look at it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on pull request #10514: Truly clear tis before runing dag test
Posted by GitBox <gi...@apache.org>.
turbaszek commented on pull request #10514:
URL: https://github.com/apache/airflow/pull/10514#issuecomment-686368171
@michalslowikowski00 can you please check if this issue exists in the system test? Running a test and then removing a task from example a dag should be enough to check it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] stale[bot] closed pull request #10514: Truly clear tis before runing dag test
Posted by GitBox <gi...@apache.org>.
stale[bot] closed pull request #10514:
URL: https://github.com/apache/airflow/pull/10514
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #10514: Truly clear tis before runing dag test
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #10514:
URL: https://github.com/apache/airflow/pull/10514#issuecomment-686815838
@turbaszek Be warned that this PR does not run all tests on CI.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] michalslowikowski00 edited a comment on pull request #10514: Truly clear tis before runing dag test
Posted by GitBox <gi...@apache.org>.
michalslowikowski00 edited a comment on pull request #10514:
URL: https://github.com/apache/airflow/pull/10514#issuecomment-682459950
I am testing in right now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] michalslowikowski00 commented on pull request #10514: Truly clear tis before runing dag test
Posted by GitBox <gi...@apache.org>.
michalslowikowski00 commented on pull request #10514:
URL: https://github.com/apache/airflow/pull/10514#issuecomment-682457298
```
tests/providers/google/cloud/operators/test_dataprep_system.py::DataprepExampleDagsTest::test_run_example_dag ========================= AIRFLOW ==========================
Home of the user: /root
Airflow home /root/airflow
Skipping initializing of the DB as it was initialized already.
You can re-initialize the database by adding --with-db-init flag when running tests.
Removing all log files except previous_runs
```
Should it be prompt after this fix `Removing all log files except previous_runs`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] michalslowikowski00 removed a comment on pull request #10514: Truly clear tis before runing dag test
Posted by GitBox <gi...@apache.org>.
michalslowikowski00 removed a comment on pull request #10514:
URL: https://github.com/apache/airflow/pull/10514#issuecomment-682457298
```
tests/providers/google/cloud/operators/test_dataprep_system.py::DataprepExampleDagsTest::test_run_example_dag ========================= AIRFLOW ==========================
Home of the user: /root
Airflow home /root/airflow
Skipping initializing of the DB as it was initialized already.
You can re-initialize the database by adding --with-db-init flag when running tests.
Removing all log files except previous_runs
```
Should it be prompt after this fix `Removing all log files except previous_runs`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] michalslowikowski00 commented on pull request #10514: Truly clear tis before runing dag test
Posted by GitBox <gi...@apache.org>.
michalslowikowski00 commented on pull request #10514:
URL: https://github.com/apache/airflow/pull/10514#issuecomment-682465463
It works as expected. Thanks @turbaszek.
Will it reflect on system tests? I am asking because in sys tests I noticed such log `Removing all log files except previous_runs`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] michalslowikowski00 commented on pull request #10514: Truly clear tis before runing dag test
Posted by GitBox <gi...@apache.org>.
michalslowikowski00 commented on pull request #10514:
URL: https://github.com/apache/airflow/pull/10514#issuecomment-682459950
I am testing in right know.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org