You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "xinrong-meng (via GitHub)" <gi...@apache.org> on 2025/09/15 18:51:26 UTC
[PR] [SPARK-53584][PYTHON] Improve process_column_param validation and column parameter docstring [spark]
xinrong-meng opened a new pull request, #52344:
URL: https://github.com/apache/spark/pull/52344
### What changes were proposed in this pull request?
- process_column_param: from repeated linear scans of data.schema.fields to a one-time dictionary build, makes validation faster especially for wide schemas.
- Clarified the behavior when column=None in docstrings
### Why are the changes needed?
Ensure user-facing docs describe behavior in edge cases without confusion; improve performance of column validation.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Existing tests
### Was this patch authored or co-authored using generative AI tooling?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-53584][PYTHON] Improve process_column_param validation and column parameter docstring [spark]
Posted by "xinrong-meng (via GitHub)" <gi...@apache.org>.
xinrong-meng commented on PR #52344:
URL: https://github.com/apache/spark/pull/52344#issuecomment-3299874307
Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org