[jira] [Closed] (OFBIZ-4652) The Label Manager is wrongly overriding CommonEmptyHeader

["Jacques Le Roux (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/OFBIZ-4652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-4652.
----------------------------------

       Resolution: Fixed
    Fix Version/s: Release Branch 12.04
                   SVN trunk
                   Release Branch 11.04
                   Release Branch 10.04
         Assignee: Jacques Le Roux

Fixed in
trunk r1338831
R12.04 r1338836
R11.04 r1338842
R10.04 r1338843

* Adds a keepSpace boolean to UtilXml.writeXmlDocument(), this allows to use xsl:preserve-space into UtilXml.createOutputTransformer()
* Uses it into SaveLabelsToXmlFile.saveLabelsToXmlFile()
* Adds some French labels into CommonUiLabels.xml using Labels Manager to test the new functionality 
* Adds the xml:space attribute into the valueType complexType
* Adds the ofbiz-properties.xsd schema into the base-catalog.xml

I got an issue when 1st trying to commit: 
Commit failed (details follow):
While preparing
 'D:\workspace\ofbizClean\framework\common\config\CommonUiLabels.xml' for commit
Inconsistent line ending style

So I forced the EOLs to my locale platform value (Win XP)

                
> The Label Manager is wrongly overriding CommonEmptyHeader
> ---------------------------------------------------------
>
>                 Key: OFBIZ-4652
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4652
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Release 09.04, Release 10.04, Release Branch 11.04, SVN trunk
>            Reporter: Jacques Le Roux
>            Assignee: Jacques Le Roux
>              Labels: labe, manager
>             Fix For: Release Branch 10.04, Release Branch 11.04, SVN trunk, Release Branch 12.04
>
>
> So 
> <xml:lang="en" xml:space="preserve">
> is replaced by
> <value xml:lang="en" xml:space="preserve"/> 
> We shoul also add </value><!-- do not  remove this! --> to docvument the feature (todo better, more a reminder)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira