You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by JoshRosen <gi...@git.apache.org> on 2015/02/08 00:39:18 UTC
[GitHub] spark pull request: [SPARK-5671] Upgrade jets3t to 0.9.2 in hadoop...
GitHub user JoshRosen opened a pull request:
https://github.com/apache/spark/pull/4454
[SPARK-5671] Upgrade jets3t to 0.9.2 in hadoop-2.3 and 2.4 profiles
Upgrading from jets3t 0.9.0 to 0.9.2 fixes a dependency issue that was
causing UISeleniumSuite to fail with ClassNotFoundExceptions when run
the hadoop-2.3 or hadoop-2.4 profiles.
The jets3t release notes can be found at http://www.jets3t.org/RELEASE_NOTES.html
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/JoshRosen/spark SPARK-5671
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/4454.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4454
----
commit fa6cb3e362fdaa31dbe661e298a477556b602987
Author: Josh Rosen <jo...@databricks.com>
Date: 2015-02-07T23:35:57Z
[SPARK-5671] Upgrade jets3t to 0.9.2 in hadoop-2.3 and 2.4 profiles
Upgrading from jets3t 0.9.0 to 0.9.2 fixes a dependency issue that was
causing UISeleniumSuite to fail with ClassNotFoundExceptions when run
the hadoop-2.3 or hadoop-2.4 profiles.
The jets3t release notes can be found at http://www.jets3t.org/RELEASE_NOTES.html
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-5671] Upgrade jets3t to 0.9.2 in hadoop...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/4454#issuecomment-73389415
+1 to updating to 0.9.2 (0.9.3 even?) for all the reasons you've cited here. There wasn't a reason not to update before, just not obviously a reason to. Now there is.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-5671] Upgrade jets3t to 0.9.2 in hadoop...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4454#issuecomment-73391304
[Test build #27017 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27017/consoleFull) for PR 4454 at commit [`fa6cb3e`](https://github.com/apache/spark/commit/fa6cb3e362fdaa31dbe661e298a477556b602987).
* This patch **passes all tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-5671] Upgrade jets3t to 0.9.2 in hadoop...
Posted by JoshRosen <gi...@git.apache.org>.
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/4454#issuecomment-73389107
/cc @pwendell @srowen.
Note that we had previously rejected a patch that would have done this same version bumping, but I think that was because there wasn't a Spark-specific motivation for upgrading: https://github.com/apache/spark/pull/3654#issuecomment-66409892
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-5671] Upgrade jets3t to 0.9.2 in hadoop...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/4454
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-5671] Upgrade jets3t to 0.9.2 in hadoop...
Posted by JoshRosen <gi...@git.apache.org>.
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/4454#issuecomment-73389329
Note that the actual dependency conflict here involves an old version of `httpcomponets.httpclient` being pulled in via the `jets3t` dependency. I ran into a variant of this problem when working on the original PR for the UISeleniumSuite (#2474) but didn't have to add a workaround for it there since some build changes in other PRs ended up fixing this issue.
I think we need version 4.2.3 or higher of `httpcomponents.httpclient`, but jets3t 0.9.0 depends on 4.1.2, which is why the older version was causing a problem here.
I guess we could fix this by adding an explicit test-scoped dependency on the newer version of `httpcomponents`, but I thought this approach seemed easier unless there's a strong motivation to not upgrade to 0.9.2.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-5671] Upgrade jets3t to 0.9.2 in hadoop...
Posted by JoshRosen <gi...@git.apache.org>.
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/4454#issuecomment-73389447
It looks like 0.9.3 has been released, but it's not on Maven Central yet: http://search.maven.org/#search%7Cga%7C1%7Cg%3A%22net.java.dev.jets3t%22
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-5671] Upgrade jets3t to 0.9.2 in hadoop...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4454#issuecomment-73391310
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27017/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-5671] Upgrade jets3t to 0.9.2 in hadoop...
Posted by JoshRosen <gi...@git.apache.org>.
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/4454#issuecomment-73389145
@pwendell if you want to reproduce the old UISeleniumSuite Jenkins failures locally, you can run
```
build/mvn -Pyarn -Phadoop-2.3 -Dhadoop.version=2.3.0 test -DwildcardSuites=org.apache.spark.ui.UISeleniumSuite -Dtest=none
```
after packaging Spark.
I ran this locally to confirm that this patch fixes that issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-5671] Upgrade jets3t to 0.9.2 in hadoop...
Posted by JoshRosen <gi...@git.apache.org>.
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/4454#issuecomment-73391882
I'm going to go ahead and merge this into `master` (1.4.0) and `branch-1.3` (1.3.0) in order to un-break those Jenkins builds.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-5671] Upgrade jets3t to 0.9.2 in hadoop...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4454#issuecomment-73389146
[Test build #27017 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27017/consoleFull) for PR 4454 at commit [`fa6cb3e`](https://github.com/apache/spark/commit/fa6cb3e362fdaa31dbe661e298a477556b602987).
* This patch merges cleanly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org