Re: [PR] fix(bigquery): limit result set size to prevent browser memory crashes [superset]

["rusackas (via GitHub)" <gi...@apache.org>]

rusackas commented on PR #38588:
URL: https://github.com/apache/superset/pull/38588#issuecomment-4522165874

   Thanks for the careful review @aminghadersohi! Applied all four in 03521a4:
   
   - ✅ **MEDIUM**: `bigquery.py:317` switched to `current_app.config["BQ_FETCH_MAX_MB"]`. Added a comment noting the 200 fallback is only used when running outside an app context.
   - ✅ **NIT**: extracted `1000` to `_BQ_INITIAL_SAMPLE_ROWS` module-level constant with docstring.
   - ✅ **NIT**: added a comment to the broad `except Exception` naming expected failure modes (DB-API errors, network/auth timeouts, `sys.getsizeof` on unknown cell types, future `Row` subclasses).
   - ✅ **NIT**: added `-> None` return annotations to both `test_get_df_payload_bq_memory_limited_*` test functions.
   
   Pre-commit (ruff/mypy/pylint) all pass locally. Should be green and ready to merge once CI re-runs.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org