You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "magicgoody (via GitHub)" <gi...@apache.org> on 2023/08/21 13:28:11 UTC

[GitHub] [beam] magicgoody opened a new pull request, #28075: Add Publish JUnit Test Results Action

magicgoody opened a new pull request, #28075:
URL: https://github.com/apache/beam/pull/28075

   This PR was created to add an action that visualize the results of JUnit tests and adds them to the workflow summary page and the PR page (if the PR exists).
   
   The action requires additional permissions:
   pull-requests: write (allow adding the test result to the PR page)
   checks: write (allow to add test result to workflow summary page)
   issues: write (allow to add the test result in order if the issue was created or it was a comment/push)
   
   Example runs:
   Push: https://github.com/magicgoody/beam/actions/runs/5926105477
   Pull_request_target: https://github.com/magicgoody/beam/actions/runs/5926531661
   
   ![image](https://github.com/apache/beam/assets/131876064/dd7eb47f-5192-4ee0-acde-49a1e3d68de7)
   
   
   ------------------------
   
   Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
    - [ ] Update `CHANGES.md` with noteworthy changes.
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier).
   
   To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
   
   GitHub Actions Tests Status (on master branch)
   ------------------------------------------------------------------------------------------------
   [![Build python source distribution and wheels](https://github.com/apache/beam/workflows/Build%20python%20source%20distribution%20and%20wheels/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
   [![Python tests](https://github.com/apache/beam/workflows/Python%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Java tests](https://github.com/apache/beam/workflows/Java%20Tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Go tests](https://github.com/apache/beam/workflows/Go%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
   
   See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI or the [workflows README](https://github.com/apache/beam/blob/master/.github/workflows/README.md) to see a list of phrases to trigger workflows.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] github-actions[bot] commented on pull request #28075: Add Publish JUnit Test Results Action

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #28075:
URL: https://github.com/apache/beam/pull/28075#issuecomment-1693151646

   Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
   
   R: @Abacn for label build.
   
   Available commands:
   - `stop reviewer notifications` - opt out of the automated review tooling
   - `remind me after tests pass` - tag the comment author after tests pass
   - `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
   
   The PR bot will only process comments in the main thread (not review comments).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] Abacn merged pull request #28075: Add Publish JUnit Test Results Action

Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn merged PR #28075:
URL: https://github.com/apache/beam/pull/28075


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] magicgoody commented on pull request #28075: Add Publish JUnit Test Results Action

Posted by "magicgoody (via GitHub)" <gi...@apache.org>.
magicgoody commented on PR #28075:
URL: https://github.com/apache/beam/pull/28075#issuecomment-1717085547

   Hello @Abacn 
   Sure, thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] magicgoody commented on pull request #28075: Add Publish JUnit Test Results Action

Posted by "magicgoody (via GitHub)" <gi...@apache.org>.
magicgoody commented on PR #28075:
URL: https://github.com/apache/beam/pull/28075#issuecomment-1702406461

   Third party action is blocked, the workflow is not running
   ![image](https://github.com/apache/beam/assets/131876064/f4731a78-0808-41ac-91e6-cf0890da9f54)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] Abacn commented on pull request #28075: Add Publish JUnit Test Results Action

Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on PR #28075:
URL: https://github.com/apache/beam/pull/28075#issuecomment-1697523078

   third party action needs apache infra's approval to be able to run. Shall I make a request?
   
   Also, if there is a test failure, is it possible to see which test and what is the reason for failure? This is the useful part. A summary of how many test run is already available in the log page, but currently the inconvenience for existing github action workflow is that when there is a  test failure, there is no way to see the stack trace.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] Abacn commented on pull request #28075: Add Publish JUnit Test Results Action

Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on PR #28075:
URL: https://github.com/apache/beam/pull/28075#issuecomment-1714643000

   Update: the third party workflow is whitelisted. I see a green run: https://github.com/apache/beam/actions/runs/6150041760/job/16687179322
   
   But also there is failing run "Invalid workflow file
   The workflow is not valid. Maximum object size exceeded"
   
   https://github.com/apache/beam/actions/runs/6151946870/workflow
   
   Will keep monitoring


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] magicgoody commented on pull request #28075: Add Publish JUnit Test Results Action

Posted by "magicgoody (via GitHub)" <gi...@apache.org>.
magicgoody commented on PR #28075:
URL: https://github.com/apache/beam/pull/28075#issuecomment-1700970202

   Hello @Abacn 
   
   Thank you for your comment
   I did a run where one task failed and the error was shown in the Test Results Summary tab.
   
   Workflow run
   https://github.com/magicgoody/beam/actions/runs/6036390451/job/16380099633
   
   Summary Result
   ![image](https://github.com/apache/beam/assets/131876064/a39ca546-9216-4071-b33b-b9b8f69a06e5)
   
   Task with Error
   ![image](https://github.com/apache/beam/assets/131876064/359a05af-12ba-4454-bb67-f0576b3fb51a)
   
   
   
   Here is the README file for the related github action used.
   https://github.com/EnricoMi/publish-unit-test-result-action/blob/v2.9.0/README.md
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] Abacn commented on pull request #28075: Add Publish JUnit Test Results Action

Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on PR #28075:
URL: https://github.com/apache/beam/pull/28075#issuecomment-1714652977

   Also, when we apply this plugin to all other java tests, can we also change the uploaded archive for "JUnit Test Results" from `**/build/test-results/**/*.xml` to `**/build/reports/tests/` here, and change the condition to
   ```
   if: failure()
   ```
   so it would upload human readable detailed test results on failure.
   
   https://github.com/apache/beam/blob/3304e1258b3268fbdd29de14d35a0da3644493e7/.github/workflows/beam_PreCommit_SQL_Java17.yml#L111
   
   The current xml is not human readable, and `**/build/reports/tests/` contains html that include both stack trace and stdout / stderr


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] chamikaramj commented on pull request #28075: Add Publish JUnit Test Results Action

Posted by "chamikaramj (via GitHub)" <gi...@apache.org>.
chamikaramj commented on PR #28075:
URL: https://github.com/apache/beam/pull/28075#issuecomment-1696432169

   @Abacn could you check or suggest a reviewer ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] Abacn commented on pull request #28075: Add Publish JUnit Test Results Action

Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on PR #28075:
URL: https://github.com/apache/beam/pull/28075#issuecomment-1701481224

   Let's get this in and see if the workflow also runs on beam repo. Possible need request permission to infra


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] Abacn commented on pull request #28075: Add Publish JUnit Test Results Action

Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on PR #28075:
URL: https://github.com/apache/beam/pull/28075#issuecomment-1703946327

   As expected. created https://issues.apache.org/jira/browse/INFRA-24950 requesting enabling this action


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org