You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2021/11/19 03:45:29 UTC
[GitHub] [ozone] guihecheng opened a new pull request #2855: HDDS-6019. Fix s3g create key error in cluster with replication one.
guihecheng opened a new pull request #2855:
URL: https://github.com/apache/ozone/pull/2855
## What changes were proposed in this pull request?
Fix s3g create key error in cluster with replication one.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-6019
## How was this patch tested?
manual test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] bharatviswa504 merged pull request #2855: HDDS-6019. Fix s3g create key error in cluster with replication one.
Posted by GitBox <gi...@apache.org>.
bharatviswa504 merged pull request #2855:
URL: https://github.com/apache/ozone/pull/2855
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] bharatviswa504 commented on pull request #2855: HDDS-6019. Fix s3g create key error in cluster with replication one.
Posted by GitBox <gi...@apache.org>.
bharatviswa504 commented on pull request #2855:
URL: https://github.com/apache/ozone/pull/2855#issuecomment-978721237
Thank You @guihecheng for the contribution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] bharatviswa504 commented on a change in pull request #2855: HDDS-6019. Fix s3g create key error in cluster with replication one.
Posted by GitBox <gi...@apache.org>.
bharatviswa504 commented on a change in pull request #2855:
URL: https://github.com/apache/ozone/pull/2855#discussion_r755600417
##########
File path: hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/util/S3StorageType.java
##########
@@ -48,8 +50,17 @@ public ReplicationType getType() {
return type;
}
- public static S3StorageType getDefault() {
- return STANDARD;
+ public static S3StorageType getDefault(ConfigurationSource config) {
Review comment:
Can we add JavaDoc for this.
And also what is the reason if config has wrong value, falling back to STANDARD?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] guihecheng commented on a change in pull request #2855: HDDS-6019. Fix s3g create key error in cluster with replication one.
Posted by GitBox <gi...@apache.org>.
guihecheng commented on a change in pull request #2855:
URL: https://github.com/apache/ozone/pull/2855#discussion_r755633576
##########
File path: hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/util/S3StorageType.java
##########
@@ -48,8 +50,17 @@ public ReplicationType getType() {
return type;
}
- public static S3StorageType getDefault() {
- return STANDARD;
+ public static S3StorageType getDefault(ConfigurationSource config) {
Review comment:
@bharatviswa504 sure, I'll add more descriptions.
Yes, for now I just try to fallback to STANDARD.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org