You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by yanboliang <gi...@git.apache.org> on 2016/04/18 18:14:43 UTC

[GitHub] spark pull request: [SPARK-13961][ML] spark.ml ChiSqSelector and R...

Github user yanboliang commented on the pull request:

    https://github.com/apache/spark/pull/12467#issuecomment-211451163
  
    @BenFradet Thanks for this PR. I think we can not make ```RFormula``` supporting other numeric types for label as your proposal. If the label column already exists, it must be type of DoubleType, otherwise it will cause the downstream model can not recognize the label column when ```validateAndTransformSchema```.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org