You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2019/08/25 03:05:13 UTC

[GitHub] [rocketmq-client-go] codecov-io commented on issue #177: [ISSUE #176]add ctx to rmqClient & remoteClient

codecov-io commented on issue #177: [ISSUE  #176]add ctx to rmqClient & remoteClient
URL: https://github.com/apache/rocketmq-client-go/pull/177#issuecomment-524596294
 
 
   # [Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/177?src=pr&el=h1) Report
   > Merging [#177](https://codecov.io/gh/apache/rocketmq-client-go/pull/177?src=pr&el=desc) into [native](https://codecov.io/gh/apache/rocketmq-client-go/commit/1ee23b73fe4008bbc05f4b625f6e6c59c81dbc94?src=pr&el=desc) will **increase** coverage by `0.53%`.
   > The diff coverage is `33.87%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/rocketmq-client-go/pull/177/graphs/tree.svg?width=650&token=CiV9ofPkG3&height=150&src=pr)](https://codecov.io/gh/apache/rocketmq-client-go/pull/177?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           native     #177      +/-   ##
   ==========================================
   + Coverage   24.44%   24.98%   +0.53%     
   ==========================================
     Files          45       45              
     Lines        4635     4583      -52     
   ==========================================
   + Hits         1133     1145      +12     
   + Misses       3351     3289      -62     
   + Partials      151      149       -2
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/rocketmq-client-go/pull/177?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [internal/mock\_client.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/177/diff?src=pr&el=tree#diff-aW50ZXJuYWwvbW9ja19jbGllbnQuZ28=) | `0% <0%> (ø)` | :arrow_up: |
   | [internal/trace.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/177/diff?src=pr&el=tree#diff-aW50ZXJuYWwvdHJhY2UuZ28=) | `32.9% <0%> (ø)` | :arrow_up: |
   | [internal/remote/mock\_remote\_client.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/177/diff?src=pr&el=tree#diff-aW50ZXJuYWwvcmVtb3RlL21vY2tfcmVtb3RlX2NsaWVudC5nbw==) | `0% <0%> (ø)` | :arrow_up: |
   | [consumer/push\_consumer.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/177/diff?src=pr&el=tree#diff-Y29uc3VtZXIvcHVzaF9jb25zdW1lci5nbw==) | `15.66% <0%> (ø)` | :arrow_up: |
   | [internal/client.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/177/diff?src=pr&el=tree#diff-aW50ZXJuYWwvY2xpZW50Lmdv) | `0.29% <0%> (ø)` | :arrow_up: |
   | [consumer/consumer.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/177/diff?src=pr&el=tree#diff-Y29uc3VtZXIvY29uc3VtZXIuZ28=) | `3.86% <0%> (ø)` | :arrow_up: |
   | [internal/remote/future.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/177/diff?src=pr&el=tree#diff-aW50ZXJuYWwvcmVtb3RlL2Z1dHVyZS5nbw==) | `100% <100%> (ø)` | :arrow_up: |
   | [internal/remote/remote\_client.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/177/diff?src=pr&el=tree#diff-aW50ZXJuYWwvcmVtb3RlL3JlbW90ZV9jbGllbnQuZ28=) | `52.48% <100%> (+0.33%)` | :arrow_up: |
   | [internal/route.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/177/diff?src=pr&el=tree#diff-aW50ZXJuYWwvcm91dGUuZ28=) | `5.1% <100%> (ø)` | :arrow_up: |
   | [consumer/offset\_store.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/177/diff?src=pr&el=tree#diff-Y29uc3VtZXIvb2Zmc2V0X3N0b3JlLmdv) | `68.06% <50%> (ø)` | :arrow_up: |
   | ... and [2 more](https://codecov.io/gh/apache/rocketmq-client-go/pull/177/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/177?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/177?src=pr&el=footer). Last update [1ee23b7...084feee](https://codecov.io/gh/apache/rocketmq-client-go/pull/177?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services