[GitHub] [pulsar] nodece commented on a diff in pull request #16792: [improve][broker] enhance grant permission module to reduce zk metadata

[GitBox <gi...@apache.org>]

nodece commented on code in PR #16792:
URL: https://github.com/apache/pulsar/pull/16792#discussion_r996635694


##########
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authorization/PulsarAuthorizationProvider.java:
##########
@@ -247,7 +247,8 @@ public CompletableFuture<Void> grantPermissionAsync(TopicName topicName, Set<Aut
                 }
                 throw new IllegalStateException("policies are in readonly mode");
             }
-            String topicUri = topicName.toString();
+            // Enhancement: only grant permission on based topic
+            String topicUri = topicName.getPartitionedTopicName();

Review Comment:
   Good catch! All partitions should have the same permissions, is that right?
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org