You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Guangya Liu <gy...@gmail.com> on 2016/01/15 08:19:38 UTC
Review Request 42342: Added a new test cases for revive offer.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42342/
-----------------------------------------------------------
Review request for mesos, Ben Mahler and Vinod Kone.
Bugs: MESOS-4387
https://issues.apache.org/jira/browse/MESOS-4387
Repository: mesos
Description
-------
Added a new test cases for revive offer.
Diffs
-----
src/tests/hierarchical_allocator_tests.cpp e044f832c2c16e53e663c6ced5452649bb0dcb59
Diff: https://reviews.apache.org/r/42342/diff/
Testing
-------
make
make check
GLOG_v=2 ./bin/mesos-tests.sh --gtest_filter="HierarchicalAllocatorTest.ReviveOffers" --verbose
Thanks,
Guangya Liu
Re: Review Request 42342: Added a new test cases for revive offer.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42342/#review118646
-----------------------------------------------------------
Ship it!
Ship It!
- haosdent huang
On Feb. 10, 2016, 5:09 a.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42342/
> -----------------------------------------------------------
>
> (Updated Feb. 10, 2016, 5:09 a.m.)
>
>
> Review request for mesos, Ben Mahler and Vinod Kone.
>
>
> Bugs: MESOS-4387
> https://issues.apache.org/jira/browse/MESOS-4387
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a new test cases for revive offer.
>
>
> Diffs
> -----
>
> src/tests/hierarchical_allocator_tests.cpp 990f3723d52dfeaa19d5eb0603c0fc7eb2b362c7
>
> Diff: https://reviews.apache.org/r/42342/diff/
>
>
> Testing
> -------
>
> make
> make check
> GLOG_v=2 ./bin/mesos-tests.sh --gtest_filter="HierarchicalAllocatorTest.ReviveOffers" --verbose
>
>
> Thanks,
>
> Guangya Liu
>
>
Re: Review Request 42342: Added a new test cases for revive offer.
Posted by Guangya Liu <gy...@gmail.com>.
> On 二月 10, 2016, 11:32 a.m., haosdent huang wrote:
> > src/tests/hierarchical_allocator_tests.cpp, line 2409
> > <https://reviews.apache.org/r/42342/diff/3/?file=1239306#file1239306line2409>
> >
> > should we settle before `advance`
I think it should be OK as long as the `settle` is before `allocations.get()`, because I need to make sure the `recoverResources` is finished before get `allocations`.
- Guangya
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42342/#review118627
-----------------------------------------------------------
On 二月 10, 2016, 5:09 a.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42342/
> -----------------------------------------------------------
>
> (Updated 二月 10, 2016, 5:09 a.m.)
>
>
> Review request for mesos, Ben Mahler and Vinod Kone.
>
>
> Bugs: MESOS-4387
> https://issues.apache.org/jira/browse/MESOS-4387
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a new test cases for revive offer.
>
>
> Diffs
> -----
>
> src/tests/hierarchical_allocator_tests.cpp 990f3723d52dfeaa19d5eb0603c0fc7eb2b362c7
>
> Diff: https://reviews.apache.org/r/42342/diff/
>
>
> Testing
> -------
>
> make
> make check
> GLOG_v=2 ./bin/mesos-tests.sh --gtest_filter="HierarchicalAllocatorTest.ReviveOffers" --verbose
>
>
> Thanks,
>
> Guangya Liu
>
>
Re: Review Request 42342: Added a new test cases for revive offer.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42342/#review118627
-----------------------------------------------------------
src/tests/hierarchical_allocator_tests.cpp (line 2409)
<https://reviews.apache.org/r/42342/#comment179918>
should we settle before `advance`
- haosdent huang
On Feb. 10, 2016, 5:09 a.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42342/
> -----------------------------------------------------------
>
> (Updated Feb. 10, 2016, 5:09 a.m.)
>
>
> Review request for mesos, Ben Mahler and Vinod Kone.
>
>
> Bugs: MESOS-4387
> https://issues.apache.org/jira/browse/MESOS-4387
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a new test cases for revive offer.
>
>
> Diffs
> -----
>
> src/tests/hierarchical_allocator_tests.cpp 990f3723d52dfeaa19d5eb0603c0fc7eb2b362c7
>
> Diff: https://reviews.apache.org/r/42342/diff/
>
>
> Testing
> -------
>
> make
> make check
> GLOG_v=2 ./bin/mesos-tests.sh --gtest_filter="HierarchicalAllocatorTest.ReviveOffers" --verbose
>
>
> Thanks,
>
> Guangya Liu
>
>
Re: Review Request 42342: Added a new test cases for revive offer.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42342/#review118626
-----------------------------------------------------------
Patch looks great!
Reviews applied: [39628, 42342]
Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On Feb. 10, 2016, 5:09 a.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42342/
> -----------------------------------------------------------
>
> (Updated Feb. 10, 2016, 5:09 a.m.)
>
>
> Review request for mesos, Ben Mahler and Vinod Kone.
>
>
> Bugs: MESOS-4387
> https://issues.apache.org/jira/browse/MESOS-4387
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a new test cases for revive offer.
>
>
> Diffs
> -----
>
> src/tests/hierarchical_allocator_tests.cpp 990f3723d52dfeaa19d5eb0603c0fc7eb2b362c7
>
> Diff: https://reviews.apache.org/r/42342/diff/
>
>
> Testing
> -------
>
> make
> make check
> GLOG_v=2 ./bin/mesos-tests.sh --gtest_filter="HierarchicalAllocatorTest.ReviveOffers" --verbose
>
>
> Thanks,
>
> Guangya Liu
>
>
Re: Review Request 42342: Added a new test cases for revive offer.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42342/
-----------------------------------------------------------
(Updated 二月 10, 2016, 5:09 a.m.)
Review request for mesos, Ben Mahler and Vinod Kone.
Changes
-------
Rebase. @Viond, can you please help review this again? Thanks.
Bugs: MESOS-4387
https://issues.apache.org/jira/browse/MESOS-4387
Repository: mesos
Description
-------
Added a new test cases for revive offer.
Diffs (updated)
-----
src/tests/hierarchical_allocator_tests.cpp 990f3723d52dfeaa19d5eb0603c0fc7eb2b362c7
Diff: https://reviews.apache.org/r/42342/diff/
Testing
-------
make
make check
GLOG_v=2 ./bin/mesos-tests.sh --gtest_filter="HierarchicalAllocatorTest.ReviveOffers" --verbose
Thanks,
Guangya Liu
Re: Review Request 42342: Added a new test cases for revive offer.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42342/#review114844
-----------------------------------------------------------
Patch looks great!
Reviews applied: [39628, 42342]
Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh
- Mesos ReviewBot
On Jan. 16, 2016, 2:52 a.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42342/
> -----------------------------------------------------------
>
> (Updated Jan. 16, 2016, 2:52 a.m.)
>
>
> Review request for mesos, Ben Mahler and Vinod Kone.
>
>
> Bugs: MESOS-4387
> https://issues.apache.org/jira/browse/MESOS-4387
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a new test cases for revive offer.
>
>
> Diffs
> -----
>
> src/tests/hierarchical_allocator_tests.cpp 9362dd306497ba01e0f387c3862456cdcac6f863
>
> Diff: https://reviews.apache.org/r/42342/diff/
>
>
> Testing
> -------
>
> make
> make check
> GLOG_v=2 ./bin/mesos-tests.sh --gtest_filter="HierarchicalAllocatorTest.ReviveOffers" --verbose
>
>
> Thanks,
>
> Guangya Liu
>
>
Re: Review Request 42342: Added a new test cases for revive offer.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42342/
-----------------------------------------------------------
(Updated 一月 16, 2016, 2:52 a.m.)
Review request for mesos, Ben Mahler and Vinod Kone.
Bugs: MESOS-4387
https://issues.apache.org/jira/browse/MESOS-4387
Repository: mesos
Description
-------
Added a new test cases for revive offer.
Diffs (updated)
-----
src/tests/hierarchical_allocator_tests.cpp 9362dd306497ba01e0f387c3862456cdcac6f863
Diff: https://reviews.apache.org/r/42342/diff/
Testing
-------
make
make check
GLOG_v=2 ./bin/mesos-tests.sh --gtest_filter="HierarchicalAllocatorTest.ReviveOffers" --verbose
Thanks,
Guangya Liu
Re: Review Request 42342: Added a new test cases for revive offer.
Posted by Guangya Liu <gy...@gmail.com>.
> On 一月 15, 2016, 6:46 p.m., Vinod Kone wrote:
> > src/tests/hierarchical_allocator_tests.cpp, line 1933
> > <https://reviews.apache.org/r/42342/diff/1/?file=1198114#file1198114line1933>
> >
> > s/filter1000s/filters/
I want to hightlight that this is a 1000s filter as I saw that we also have some filters named as filter5s which means a 5s filter. What do you think?
- Guangya
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42342/#review114747
-----------------------------------------------------------
On 一月 16, 2016, 2:52 a.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42342/
> -----------------------------------------------------------
>
> (Updated 一月 16, 2016, 2:52 a.m.)
>
>
> Review request for mesos, Ben Mahler and Vinod Kone.
>
>
> Bugs: MESOS-4387
> https://issues.apache.org/jira/browse/MESOS-4387
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a new test cases for revive offer.
>
>
> Diffs
> -----
>
> src/tests/hierarchical_allocator_tests.cpp 9362dd306497ba01e0f387c3862456cdcac6f863
>
> Diff: https://reviews.apache.org/r/42342/diff/
>
>
> Testing
> -------
>
> make
> make check
> GLOG_v=2 ./bin/mesos-tests.sh --gtest_filter="HierarchicalAllocatorTest.ReviveOffers" --verbose
>
>
> Thanks,
>
> Guangya Liu
>
>
Re: Review Request 42342: Added a new test cases for revive offer.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42342/#review114747
-----------------------------------------------------------
src/tests/hierarchical_allocator_tests.cpp (line 1906)
<https://reviews.apache.org/r/42342/#comment175599>
s/revive offer/reviving offers/
src/tests/hierarchical_allocator_tests.cpp (line 1919)
<https://reviews.apache.org/r/42342/#comment175600>
s/agent1/agent/
src/tests/hierarchical_allocator_tests.cpp (line 1922)
<https://reviews.apache.org/r/42342/#comment175602>
s/framework1/framework/
s/agent1/agent/
src/tests/hierarchical_allocator_tests.cpp (line 1924)
<https://reviews.apache.org/r/42342/#comment175601>
s/framework1/framework/
src/tests/hierarchical_allocator_tests.cpp (line 1933)
<https://reviews.apache.org/r/42342/#comment175603>
s/filter1000s/filters/
src/tests/hierarchical_allocator_tests.cpp (line 1941)
<https://reviews.apache.org/r/42342/#comment175606>
s/and trigger/to trigger/
src/tests/hierarchical_allocator_tests.cpp (line 1950)
<https://reviews.apache.org/r/42342/#comment175604>
s/all//
src/tests/hierarchical_allocator_tests.cpp (line 1953)
<https://reviews.apache.org/r/42342/#comment175605>
s/framework1/framework/
- Vinod Kone
On Jan. 15, 2016, 7:19 a.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42342/
> -----------------------------------------------------------
>
> (Updated Jan. 15, 2016, 7:19 a.m.)
>
>
> Review request for mesos, Ben Mahler and Vinod Kone.
>
>
> Bugs: MESOS-4387
> https://issues.apache.org/jira/browse/MESOS-4387
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a new test cases for revive offer.
>
>
> Diffs
> -----
>
> src/tests/hierarchical_allocator_tests.cpp e044f832c2c16e53e663c6ced5452649bb0dcb59
>
> Diff: https://reviews.apache.org/r/42342/diff/
>
>
> Testing
> -------
>
> make
> make check
> GLOG_v=2 ./bin/mesos-tests.sh --gtest_filter="HierarchicalAllocatorTest.ReviveOffers" --verbose
>
>
> Thanks,
>
> Guangya Liu
>
>
Re: Review Request 42342: Added a new test cases for revive offer.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42342/#review114698
-----------------------------------------------------------
Patch looks great!
Reviews applied: [39628, 42342]
Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh
- Mesos ReviewBot
On Jan. 15, 2016, 7:19 a.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42342/
> -----------------------------------------------------------
>
> (Updated Jan. 15, 2016, 7:19 a.m.)
>
>
> Review request for mesos, Ben Mahler and Vinod Kone.
>
>
> Bugs: MESOS-4387
> https://issues.apache.org/jira/browse/MESOS-4387
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a new test cases for revive offer.
>
>
> Diffs
> -----
>
> src/tests/hierarchical_allocator_tests.cpp e044f832c2c16e53e663c6ced5452649bb0dcb59
>
> Diff: https://reviews.apache.org/r/42342/diff/
>
>
> Testing
> -------
>
> make
> make check
> GLOG_v=2 ./bin/mesos-tests.sh --gtest_filter="HierarchicalAllocatorTest.ReviveOffers" --verbose
>
>
> Thanks,
>
> Guangya Liu
>
>