You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/10/25 07:52:43 UTC
[GitHub] [camel] JiriOndrusek opened a new pull request, #8620: CAMEL-18648: Google-bigquery - fixed Exception during endpoint creation
JiriOndrusek opened a new pull request, #8620:
URL: https://github.com/apache/camel/pull/8620
fixes https://issues.apache.org/jira/browse/CAMEL-18648
<!-- Uncomment and fill this section if your PR is not trivial
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] If you're unsure, you can format the pull request title like `[CAMEL-XXX] Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the appropriate JIRA issue.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `mvn clean install -Psourcecheck` in your module with source check enabled to make sure basic checks pass and there are no checkstyle violations. A more thorough check will be performed on your pull request automatically.
Below are the contribution guidelines:
https://github.com/apache/camel/blob/main/CONTRIBUTING.md
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] orpiske merged pull request #8620: CAMEL-18648: Google-bigquery - fixed Exception during endpoint creation
Posted by GitBox <gi...@apache.org>.
orpiske merged PR #8620:
URL: https://github.com/apache/camel/pull/8620
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] orpiske commented on a diff in pull request #8620: CAMEL-18648: Google-bigquery - fixed Exception during endpoint creation
Posted by GitBox <gi...@apache.org>.
orpiske commented on code in PR #8620:
URL: https://github.com/apache/camel/pull/8620#discussion_r1004143472
##########
components/camel-google/camel-google-bigquery/src/main/java/org/apache/camel/component/google/bigquery/GoogleBigQueryConfiguration.java:
##########
@@ -59,7 +59,7 @@ public void parseRemaining(String remaining) {
projectId = parts[0];
datasetId = parts[1];
if (parts.length > 2) {
- tableId = parts[3];
+ tableId = parts[2];
Review Comment:
Oops. My bad on this one. I was trying to see if the tests would catch this but I forgot to fix it. Great catch, thanks!!!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] JiriOndrusek commented on pull request #8620: CAMEL-18648: Google-bigquery - fixed Exception during endpoint creation
Posted by GitBox <gi...@apache.org>.
JiriOndrusek commented on PR #8620:
URL: https://github.com/apache/camel/pull/8620#issuecomment-1290145313
@oscerd 3.18.x is unaffected (refactor did not happen there - [code](https://github.com/apache/camel/blob/camel-3.18.x/components/camel-google/camel-google-bigquery/src/main/java/org/apache/camel/component/google/bigquery/GoogleBigQueryConfiguration.java#L63))
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #8620: CAMEL-18648: Google-bigquery - fixed Exception during endpoint creation
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #8620:
URL: https://github.com/apache/camel/pull/8620#issuecomment-1290141171
:star2: Thank you for your contribution to the Apache Camel project! :star2:
:warning: Please note that the changes on this PR may be **tested automatically**.
If necessary Apache Camel Committers may access logs and test results in the job summaries!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #8620: CAMEL-18648: Google-bigquery - fixed Exception during endpoint creation
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #8620:
URL: https://github.com/apache/camel/pull/8620#issuecomment-1290201374
### Components tested:
| Total | Tested | Failed :x: | Passed :white_check_mark: |
| --- | --- | --- | --- |
| 1 | 1 | 0 | 1 |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] JiriOndrusek commented on a diff in pull request #8620: CAMEL-18648: Google-bigquery - fixed Exception during endpoint creation
Posted by GitBox <gi...@apache.org>.
JiriOndrusek commented on code in PR #8620:
URL: https://github.com/apache/camel/pull/8620#discussion_r1004157929
##########
components/camel-google/camel-google-bigquery/src/main/java/org/apache/camel/component/google/bigquery/GoogleBigQueryConfiguration.java:
##########
@@ -59,7 +59,7 @@ public void parseRemaining(String remaining) {
projectId = parts[0];
datasetId = parts[1];
if (parts.length > 2) {
- tableId = parts[3];
+ tableId = parts[2];
Review Comment:
Np. I upgraded test to catch it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org