[GitHub] [hbase] joshelser commented on a diff in pull request #4350: HBASE-26938 Introduce a StoreFileWriterCreationTracker

[GitBox <gi...@apache.org>]

joshelser commented on code in PR #4350:
URL: https://github.com/apache/hbase/pull/4350#discussion_r851680396


##########
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java:
##########
@@ -2406,4 +2479,15 @@ void updateMetricsStore(boolean memstoreRead) {
       mixedRowReadsCount.increment();
     }
   }
+
+  /**
+   * Return the storefiles which are currently being written to. Mainly used by
+   * {@link BrokenStoreFileCleaner} to prevent deleting the these files as they are not present in
+   * SFT yet.
+   */
+  Set<Path> getWrittenStoreFiles() {

Review Comment:
   ```suggestion
     Set<Path> getStoreFilesBeingCreated() {
   ```
   
   Maybe this instead? Trying to reflect in the name that they are still being written to. "getWrittenStoreFiles" could be read as "they were previously written to" not "actively being written to".



##########
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestMajorCompaction.java:
##########
@@ -211,26 +209,9 @@ private void majorCompaction() throws Exception {
     Result result = r.get(new Get(STARTROW).addFamily(COLUMN_FAMILY_TEXT).readVersions(100));
     assertEquals(compactionThreshold, result.size());
 
-    // see if CompactionProgress is in place but null
-    for (HStore store : r.getStores()) {
-      assertNull(store.getCompactionProgress());
-    }
-
     r.flush(true);
     r.compact(true);
 
-    // see if CompactionProgress has done its thing on at least one store
-    int storeCount = 0;
-    for (HStore store : r.getStores()) {
-      CompactionProgress progress = store.getCompactionProgress();

Review Comment:
   Do we have test coverage for `getProgress()` elsewhere?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org