[jira] Commented: (HARMONY-3584) [drlvm][jit][opt] arraycopy folding implementation in guarded manner

["Egor Pasko (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HARMONY-3584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12537233 ] 

Egor Pasko commented on HARMONY-3584:
-------------------------------------

Dmitry,

is it just arraycopy.patch needs to be committed or some other patches too? :)

did you compare it with old impl on benchmarks? plz, share your thoughts/results on them..

on your question (genArrayCopy and genCharArrayCopy): I prefer to let them (and their flags) be for a while so that they can be cleaned up later. This way we can compare how fast both are in various circumstances not having to recompile the code. Is it possible?

I see that your patch needs some minor cleanup here and there, but,unfortunately, I cannot list them all now yet (sadly it takes a lot of time to understand the patch:)



> [drlvm][jit][opt] arraycopy folding implementation in guarded manner
> --------------------------------------------------------------------
>
>                 Key: HARMONY-3584
>                 URL: https://issues.apache.org/jira/browse/HARMONY-3584
>             Project: Harmony
>          Issue Type: Sub-task
>          Components: DRLVM
>            Reporter: George Timoshenko
>            Assignee: Mikhail Fursov
>            Priority: Minor
>         Attachments: arraycopy.patch, arraycopy_pass.patch, intrinsic_patch.patch
>
>
> the feature (arraycopy call replacement) can be done in the guarded manner. When the classes of the arrays are being checked at runtime. 
> (It is not obvious if it gives a performance effect or not). 
> when this approach (guarded arraycopy call "inlining") is being implemented this optimisation should be moved out from the translator and inserted (before inliner) into the HLO path as a separate optimisation. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.