You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by "havengit (via GitHub)" <gi...@apache.org> on 2023/12/13 05:53:53 UTC
[PR] Reduce the number of vmstats data saved and improve the response speed of the instance list page [cloudstack]
havengit opened a new pull request, #8350:
URL: https://github.com/apache/cloudstack/pull/8350
### Description
This PR...
<!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!--- ******************************************************************************* -->
<!--- NOTE: AUTOMATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ******************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
### Feature/Enhancement Scale or Bug Severity
improve the following issues
https://github.com/apache/cloudstack/issues/8266
For vmstats data, the default global settings will cause a large amount of data to be stored in the database. When accessing the instance page, vmstats data will be requested, causing the page to open extremely slowly. Especially when multiple users access the instance page at the same time, the problem will be exacerbated.
My environment has about 200 running instances.
#### Feature/Enhancement Scale
- [ ] Major
- [x] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [x] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
#### How did you try to break this feature and the system with this change?
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
Because it is a modification of global settings, the test method is to directly modify the global parameters. The corresponding code modifications are for new deployments. There are no tests for newly deployed scenarios.
test environment:
ACS 4.18.0.0 + Galera mariadb server CLuster 10.6
Ubuntu 20.04+KVM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Reduce the number of vmstats data saved and improve the response speed of the instance list page [cloudstack]
Posted by "havengit (via GitHub)" <gi...@apache.org>.
havengit closed pull request #8350: Reduce the number of vmstats data saved and improve the response speed of the instance list page
URL: https://github.com/apache/cloudstack/pull/8350
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Reduce the number of vmstats data saved and improve the response speed of the instance list page [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #8350:
URL: https://github.com/apache/cloudstack/pull/8350#issuecomment-1854616816
> @DaanHoogland @havengit, the default global configuration values should only be used as a guideline, and it will not work in every environment.
>
> This feature was introduced in PR #5984 with the configuration `vm.stats.max.retention.time` with value of `1` (to maintain backward compatibility), which would not cause any problems, performance-wise. However, the default value was changed to `720` with PR #6803, which seems to be too high for larger environments. I do not think that changing the default value again is going to help anybody. Documentation regarding the combination of the parameters `vm.stats.max.retention.time` and `vm.stats.interval` would benefit everyone. IMHO, the default value `vm.stats.max.retention.time` should not have been changed since the introduction of the feature, as the operator must know its underlying systems to set its value.
+1 with documentation changes.
We should not change the default value of existing configurations, unless the value is extremely unreasonable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Reduce the number of vmstats data saved and improve the response speed of the instance list page [cloudstack]
Posted by "havengit (via GitHub)" <gi...@apache.org>.
havengit commented on PR #8350:
URL: https://github.com/apache/cloudstack/pull/8350#issuecomment-1853870517
> Is this still a draft PR, @havengit ?
This is a complete PR with very few changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Reduce the number of vmstats data saved and improve the response speed of the instance list page [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #8350:
URL: https://github.com/apache/cloudstack/pull/8350#issuecomment-1853530999
Is this still a draft PR, @havengit ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Reduce the number of vmstats data saved and improve the response speed of the instance list page [cloudstack]
Posted by "BryanMLima (via GitHub)" <gi...@apache.org>.
BryanMLima commented on PR #8350:
URL: https://github.com/apache/cloudstack/pull/8350#issuecomment-1853969785
@DaanHoogland @havengit, the default global configuration values should only be used as a guideline, and it will not work in every environment.
This feature was introduced in PR #5984 with the configuration `vm.stats.max.retention.time` with value of `1` (to maintain backward compatibility), which would not cause any problems, performance-wise. However, the default value was changed to `720` with PR #6803, which seems to be too high for larger environments. I do not think that changing the default value again is going to help anybody. Documentation regarding the combination of the parameters `vm.stats.max.retention.time` and `vm.stats.interval` would benefit everyone. IMHO, the default value `vm.stats.max.retention.time` should not have been changed since the introduction of the feature, as the operator must know its underlying systems to set its value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Reduce the number of vmstats data saved and improve the response speed of the instance list page [cloudstack]
Posted by "havengit (via GitHub)" <gi...@apache.org>.
havengit commented on PR #8350:
URL: https://github.com/apache/cloudstack/pull/8350#issuecomment-1855007970
That makes sense, I'll close this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org