You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "abhi-ksolves (via GitHub)" <gi...@apache.org> on 2024/08/14 09:42:09 UTC
[PR] KAFKA-14262: Deletion of MirrorMaker v1 deprecated classes & tests [kafka]
abhi-ksolves opened a new pull request, #16879:
URL: https://github.com/apache/kafka/pull/16879
This PR removes the Mirror Maker v1 classes and tests, as they have been deprecated according to [KIP-720](https://cwiki.apache.org/confluence/display/KAFKA/KIP-720%3A+Deprecate+MirrorMaker+v1)
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-14262: Deletion of MirrorMaker v1 deprecated classes & tests [kafka]
Posted by "abhi-ksolves (via GitHub)" <gi...@apache.org>.
abhi-ksolves commented on PR #16879:
URL: https://github.com/apache/kafka/pull/16879#issuecomment-2311737969
Hi @chia7712
Mentioned scripts & tests files are removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-14262: Deletion of MirrorMaker v1 deprecated classes & tests [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on code in PR #16879:
URL: https://github.com/apache/kafka/pull/16879#discussion_r1716878261
##########
docs/upgrade.html:
##########
@@ -845,7 +845,7 @@ <h5><a id="upgrade_300_notable" href="#upgrade_300_notable">Notable changes in 3
<code>DefaultReplicationPolicy</code>, cannot prevent replication cycles based on topic names, so take care to avoid cycles when constructing your
replication topology.
</li>
- <li> The original MirrorMaker (MM1) and related classes have been deprecated. Please use the Connect-based
+ <li> The original MirrorMaker (MM1) and related classes have been removed. Please use the Connect-based
Review Comment:
This doc is related to 3.0.0 release, and hence we should not change it. Could you please add new entry for 4.0.0 release?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-14262: Deletion of MirrorMaker v1 deprecated classes & tests [kafka]
Posted by "abhi-ksolves (via GitHub)" <gi...@apache.org>.
abhi-ksolves commented on code in PR #16879:
URL: https://github.com/apache/kafka/pull/16879#discussion_r1719430641
##########
docs/upgrade.html:
##########
@@ -845,7 +845,7 @@ <h5><a id="upgrade_300_notable" href="#upgrade_300_notable">Notable changes in 3
<code>DefaultReplicationPolicy</code>, cannot prevent replication cycles based on topic names, so take care to avoid cycles when constructing your
replication topology.
</li>
- <li> The original MirrorMaker (MM1) and related classes have been deprecated. Please use the Connect-based
+ <li> The original MirrorMaker (MM1) and related classes have been removed. Please use the Connect-based
Review Comment:
@chia7712 I have added the entry. Please review it to ensure its correctness. The entry has been added as follows: `<h4><a id="upgrade_4_0_0" href="#upgrade_4_0_0">Upgrading to 4.0.0 from any version 0.8.x through 3.9.x</a></h4>
<h5><a id="upgrade_400_notable" href="#upgrade_400_notable">Notable changes in 4.0.0</a></h5>`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-14262: Deletion of MirrorMaker v1 deprecated classes & tests [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 merged PR #16879:
URL: https://github.com/apache/kafka/pull/16879
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-14262: Deletion of MirrorMaker v1 deprecated classes & tests [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on PR #16879:
URL: https://github.com/apache/kafka/pull/16879#issuecomment-2309201764
@abhi-ksolves could you please remove related scripts and e2e?
https://github.com/apache/kafka/blob/trunk/tests/kafkatest/services/mirror_maker.py
https://github.com/apache/kafka/blob/trunk/tests/kafkatest/tests/core/mirror_maker_test.py
https://github.com/apache/kafka/blob/trunk/bin/kafka-mirror-maker.sh
https://github.com/apache/kafka/blob/trunk/bin/windows/kafka-mirror-maker.bat
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org